Skip to content

fix: enforce MAX_BLOCKS_PER_CONTENT_LIBRARY when creating containers#38801

Open
Chessing234 wants to merge 1 commit into
openedx:masterfrom
Chessing234:fix/37697-container-block-limit
Open

fix: enforce MAX_BLOCKS_PER_CONTENT_LIBRARY when creating containers#38801
Chessing234 wants to merge 1 commit into
openedx:masterfrom
Chessing234:fix/37697-container-block-limit

Conversation

@Chessing234

Copy link
Copy Markdown

Summary

create_container() did not check MAX_BLOCKS_PER_CONTENT_LIBRARY before adding a draft container, so users at the component limit could still create empty units/sections. This adds the same draft-count guard used in validate_can_add_block_to_library().

Fixes #37697

Test plan

  • Set MAX_BLOCKS_PER_CONTENT_LIBRARY to a low value (e.g. 5)
  • Create components until the limit is hit; confirm new components are rejected
  • Attempt to create a container; confirm BlockLimitReachedError is raised

Made with Cursor

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 24, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @Chessing234!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Container creation bypassed the draft-count limit that already applies to
component creation, allowing empty units/sections past the library cap.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Chessing234 Chessing234 force-pushed the fix/37697-container-block-limit branch from 46e4db8 to b6101a9 Compare June 24, 2026 16:05
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 24, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Needs Tests Run or CLA Signed in Contributions Jun 24, 2026
@mphilbrick211

Copy link
Copy Markdown

Hi @Chessing234! Welcome, and thank you for this contribution! In order for your CLA check to turn green, you'll need to submit a CLA form. If you are contributing as an individual, please fill out the individual CLA form here.

If you are contributing on behalf of an organization, please have your manager reach out to oscm@axim.org so you may be added to your org's existing entity agreement.

Please let me know if you have any questions. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs test run Author's first PR to this repository, awaiting test authorization from Axim open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Tests Run or CLA Signed

Development

Successfully merging this pull request may close these issues.

MAX_BLOCKS_PER_CONTENT_LIBRARY limit is not used when creating containers

3 participants