Skip to content

fix: Drop mock STATICFILES_STORAGE_KWARGS#38551

Merged
robrap merged 1 commit intomasterfrom
robrap/drop-mock-STATICFILES_STORAGE_KWARGS
May 6, 2026
Merged

fix: Drop mock STATICFILES_STORAGE_KWARGS#38551
robrap merged 1 commit intomasterfrom
robrap/drop-mock-STATICFILES_STORAGE_KWARGS

Conversation

@robrap
Copy link
Copy Markdown
Contributor

@robrap robrap commented May 5, 2026

The setting was misleading, because it doesn't
do anything as-is. The code that reads from this
dict uses the default of
settings.STORAGES['staticfiles']['BACKEND'], which is
openedx.core.storage.ProductionStorage, as the key.
The data under the defined (and now removed) key
openedx.core.storage.ProductionS3Storage
would never have been used.

Description

Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

The setting was misleading, because it doesn't
do anything as-is. The code that reads from this
dict would have used a different key, and the
defined key would never have been touched.
@timmc-edx
Copy link
Copy Markdown
Contributor

"A different key", meaning in place of openedx.core.storage.ProductionS3Storage, right?

@robrap
Copy link
Copy Markdown
Contributor Author

robrap commented May 5, 2026

"A different key", meaning in place of openedx.core.storage.ProductionS3Storage, right?

@timmc-edx: Yes. It would use settings.STORAGES['staticfiles']['BACKEND'] default, which is openedx.core.storage.ProductionStorage.

@robrap robrap merged commit 6efb92c into master May 6, 2026
46 checks passed
@robrap robrap deleted the robrap/drop-mock-STATICFILES_STORAGE_KWARGS branch May 6, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants