chore: lighter prod dependencies

[regisb]

We move development dependencies to devDependencies, such that npm install --omit=dev becomes faster and more lightweight. In the case of frontend-app-profile, this changes shaves off a few hundred MB of disk space.

Note the move of @babel/preset-typescript from devDependencies to
dependencies: this fixes MFE build with yarn, which was previously
failing:

git clone https://github.com/openedx/frontend-app-profile/
cd frontend-app-profile
yarn install
npm run build

Was resulting in the following error:

    ERROR in ./src/index.jsx
    Module build failed (from ./node_modules/babel-loader/lib/index.js):
    Error: Cannot find package '@babel/preset-typescript' imported from node_modules/@openedx/frontend-build/config/babel-virtual-resolve-base.js

This is because yarn does not install devDependencies of package
dependencies, as opposed to npm.

[openedx-webhooks]

Thanks for the pull request, @regisb!

This repository is currently maintained by @openedx/committers-frontend-build.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[regisb]

This is ready for review.

FYI @bradenmacdonald This builds on another pull request you opened some time ago: #566

[bradenmacdonald]

@regisb Awesome :)

[bradenmacdonald]

Note: apparently this is more contentious than I thought - see the discussion at openedx/frontend-platform#787

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (7f26332) to head (2120161).

Additional details and impacted files

@@      Coverage Diff      @@
##   master   #649   +/-   ##
=============================
=============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[itsjeyd]

Thanks for reviewing @UsamaSadiq! It looks like this PR is ready to be merged?

[UsamaSadiq]

Yes, this should be good to merge.

[regisb]

I'd like to bring in @brian-smith-tcril and @adamstankiewicz in the conversation here to get their approval, and confirm that the changes here match the decision that was made in this other PR.

[brian-smith-tcril]

If we go down this path it would need to land as a breaking change. MFEs currently rely on frontend-build having these direct dependencies.

The pattern proposed in openedx/frontend-platform#790 makes more sense to me. With that we can keep frontend-build's dependencies as-is, but treat frontend-build itself as a dev dependency.

[brian-smith-tcril]

Marking this as "change requested" until we decide if we want to go the "frontend-build as dev dependency route" or this route (and the commit message is updated so semantic release knows it is a breaking change)

[regisb]

Sounds good, just let me know what you decide and I'll update the PR accordingly.