-
Notifications
You must be signed in to change notification settings - Fork 118
feat: support design tokens and paragon 23 #1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support design tokens and paragon 23 #1173
Conversation
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
451ea51
to
9fbc2f4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master-design-tokens #1173 +/- ##
=====================================================
Coverage 66.82% 66.82%
=====================================================
Files 51 51
Lines 856 856
Branches 176 178 +2
=====================================================
Hits 572 572
Misses 273 273
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9fbc2f4
to
e84c98d
Compare
e84c98d
to
cf64142
Compare
Sandbox deployment failed 💥 |
Sandbox deployment successful 🚀 |
cf64142
to
4ecead5
Compare
Sandbox deployment successful 🚀 |
4ecead5
to
53d0b5d
Compare
Sandbox deployment failed 💥 |
Sandbox deployment successful 🚀 |
Sandbox deployment successful 🚀 |
53d0b5d
to
2349d33
Compare
Sandbox deployment successful 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this is rebased this one is good to merge!
} | ||
|
||
.profile-page { | ||
.edit-section-header { | ||
@extend .h6; | ||
font-size: var(--pgn-typography-font-size-h6-base); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is another example of openedx/frontend-app-authn#1436 (comment)
Based on openedx/frontend-app-authn#1436 (comment) moving away from @extend
in this way is good as-is!
2349d33
to
f54b198
Compare
@brian-smith-tcril rebased :) |
Sandbox deployment successful 🚀 |
747bd2f
into
openedx:master-design-tokens
Warning
This PR should not be merge to
master
directly, it should point tomaster-design-tokens
once the branch has been created.Description
This PR updates frontend app profile to support CSS variables and the corresponding paragon design tokens.
Changes implemented:
Important
This PR requires a compatible version with paragon 23 of dependencies because of that the following PRs need to be merged first:
How to test