feat: upgrade to react 18 #1663
Merged
+4,632
−3,432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
brian-smith-tcril
force-pushed
the
react-18
branch
7 times, most recently
from
32cb867 to
6769f69
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1663 +/- ##
==========================================
+ Coverage 90.09% 90.22% +0.13%
==========================================
Files 338 338
Lines 5784 5800 +16
Branches 1370 1410 +40
==========================================
+ Hits 5211 5233 +22
+ Misses 557 550 -7
- Partials 16 17 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brian-smith-tcril
force-pushed
the
react-18
branch
from
6769f69 to
0111b2d
Compare
| @@ -341,7 +341,7 @@ class Calculator extends Component { | |||
| <li>arccsch(4x+y)</li> | |||
| </ul> | |||
| </td> | |||
| <td dir="auto" /> | |||
| <td aria-label="todo: what is this? it's causing a jsx-a11y/control-has-associated-label error" dir="auto" /> | |||
There was a problem hiding this comment.
todo: figure out what's up with this
There was a problem hiding this comment.
brian-smith-tcril
added
the
create-sandbox
|
Sandbox deployment successful 🚀 |
brian-smith-tcril
force-pushed
the
react-18
branch
from
0111b2d to
e1c9149
Compare
brian-smith-tcril
force-pushed
the
react-18
branch
from
e1c9149 to
ea4d302
Compare
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of #1587