feat: add course end dashboard plugin slots #1658
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansenk
force-pushed
the
jkantor/course-end-plugins
branch
from
b200607 to
8a62a38
Compare
jansenk
requested review from
KristinAoki,
BrandonHBodine,
Rodra,
nsprenkle,
hajorg and
jristau1984
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1658 +/- ##
==========================================
+ Coverage 90.09% 90.11% +0.02%
==========================================
Files 338 340 +2
Lines 5784 5796 +12
Branches 1370 1371 +1
==========================================
+ Hits 5211 5223 +12
Misses 557 557
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KristinAoki
suggested changes
Mar 26, 2025
Comment on lines
27
to
31
| const CourseExitViewCoursesPluginSlot = ({ href }) => ( | ||
| <PluginSlot id="course_exit_view_courses_slot"> | ||
| <ViewCoursesLink content={{ href }} /> | ||
| </PluginSlot> | ||
| ); |
There was a problem hiding this comment.
Suggested change
| const CourseExitViewCoursesPluginSlot = ({ href }) => ( | |
| <PluginSlot id="course_exit_view_courses_slot"> | |
| <ViewCoursesLink content={{ href }} /> | |
| </PluginSlot> | |
| ); | |
| const CourseExitViewCoursesPluginSlot = () => { | |
| const href = `${getConfig().LMS_BASE_URL}/dashboard`; | |
| return ( | |
| <PluginSlot id="course_exit_view_courses_slot"> | |
| <ViewCoursesLink content={{ href }} /> | |
| </PluginSlot> | |
| ); | |
| }; |
| {intl.formatMessage(messages.viewCoursesButton)} | ||
| </Button> | ||
| </div> | ||
| <CourseExitViewCoursesPluginSlot href={`${getConfig().LMS_BASE_URL}/dashboard`} /> |
There was a problem hiding this comment.
Suggested change
| <CourseExitViewCoursesPluginSlot href={`${getConfig().LMS_BASE_URL}/dashboard`} /> | |
| <CourseExitViewCoursesPluginSlot /> |
See comment on plugin file
| const { courseId } = useSelector(state => state.courseware); | ||
| const { org } = useModel('courseHomeMeta', courseId); | ||
| const { administrator } = getAuthenticatedUser(); | ||
|
|
||
| const dashboardLink = ( | ||
| <Hyperlink | ||
| style={{ textDecoration: 'underline' }} | ||
| destination={`${getConfig().LMS_BASE_URL}/dashboard`} | ||
| destination={content?.dashboardFootnoteUrl || `${getConfig().LMS_BASE_URL}/dashboard`} |
There was a problem hiding this comment.
Is this conditional necessary? In the default version, you always pass in a url so it should always be defined.
KristinAoki
approved these changes
Mar 27, 2025
|
|
||
| CourseExitViewCoursesPluginSlot.propTypes = {}; | ||
|
|
||
| export default CourseExitViewCoursesPluginSlot; |
There was a problem hiding this comment.
This doesn't need to block this PR if you didn't know, but: whenever creating new files in this repo or any MFE repo, please:
- Use TypeScript
.tsxinstead of.jsx - Use TypeScript types instead of
propTypes- propTypes have been deprecated for 8 years!
You also don't need to use default exports anymore, but you can if you want to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add plugin slots to allow control of course end dashboard links