-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updated Courseware Search results for SR #1649
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @rijuma! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
68670a7
to
1a5ae39
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1649 +/- ##
=======================================
Coverage 90.09% 90.10%
=======================================
Files 338 338
Lines 5784 5788 +4
Branches 1370 1372 +2
=======================================
+ Hits 5211 5215 +4
Misses 557 557
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@rijuma Thank you for this contribution! Since it seems to include user-facing changes, you'll need to get product approval for it. When you're ready please follow the instructions from the bot to get that process started. |
Description
When showing the screen reader results the screen reader output was not very clean, it read multiple texts that weren't necessary and there was some special characters that weren't very useful.
This update is an attempt to simplify the screen reader feedback to make its navigation easier. Please compare the previous and the new demo videos to see the difference.
New version
search-sr-cleanup.mp4
Previous version
Courseware.Search.a11y.demo.mp4