Skip to content

feat: Drop canShowUpgradeSock course data. #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Mar 24, 2025

DEPR: openedx/edx-platform#36429

This piece of data is not being used anywhere but was still being
consumed so just drop the data so that the backend can be updated to no
longer provide the data.

The backend API is being updated in openedx/edx-platform#36436

DEPR: openedx/edx-platform#36429

This piece of data is not being used anywhere but was still being
consumed so just drop the data so that the backend can be updated to no
longer provide the data.

The backend API is being updated in openedx/edx-platform#36436
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (e5f04d9) to head (9260892).
Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1647   +/-   ##
=======================================
  Coverage   90.08%   90.09%           
=======================================
  Files         338      338           
  Lines        5782     5783    +1     
  Branches     1407     1407           
=======================================
+ Hits         5209     5210    +1     
  Misses        556      556           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@feanil feanil marked this pull request as ready for review March 24, 2025 18:27
@feanil feanil requested review from a team and KristinAoki March 24, 2025 18:27
@feanil feanil requested a review from arbrandes April 4, 2025 14:09
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@feanil feanil merged commit 85e6e92 into master Apr 9, 2025
7 checks passed
@feanil feanil deleted the feanil/drop_upgrade_sock_api_data branch April 9, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants