-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added the ability to close the hint using the keyboard #1605
base: master
Are you sure you want to change the base?
feat: added the ability to close the hint using the keyboard #1605
Conversation
Thanks for the pull request, @vladislavkeblysh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1605 +/- ##
==========================================
- Coverage 84.61% 84.55% -0.06%
==========================================
Files 332 332
Lines 5661 5667 +6
Branches 1391 1392 +1
==========================================
+ Hits 4790 4792 +2
- Misses 852 856 +4
Partials 19 19 ☔ View full report in Codecov by Sentry. |
914c375
to
e42a23a
Compare
@vladislavkeblysh Thank you for this contribution! Same note about product review here. |
e42a23a
to
c8c8168
Compare
Hey @vladislavkeblysh, just checking in to see if you're still planning to continue working on this PR? |
Close the tooltip using the escape