Skip to content

feat: same titles for sent email groups #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arbrandes merged 11 commits into from
Apr 17, 2026
Merged

feat: same titles for sent email groups #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c0af7ab
feat: same titles for sent email groups
Jul 3, 2024
2f59ec4
feat: aligned the checkbox labels with the BE
Jul 4, 2024
d841a2f
fix: refactor the code
ihor-romaniuk Sep 9, 2024
6d5b8a6
fix: add fall back to the recipient key
ihor-romaniuk Dec 3, 2024
80ac634
fix: lint error
ihor-romaniuk Oct 13, 2025
5621dbc
fix: remove extra class name
ihor-romaniuk Dec 2, 2025
dbe9802
chore: update package-lock.json
ihor-romaniuk Dec 2, 2025
a023929
fix: simple code improvements
ihor-romaniuk Jan 20, 2026
c0ef8fe
revert changes in package-lock file
ihor-romaniuk Jan 28, 2026
8d1e3ad
fix: address review comments for recipient display names
ihor-romaniuk Apr 16, 2026
637b9cf
fix: update package-lock file
ihor-romaniuk Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 94 additions & 10 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions src/components/bulk-email-tool/bulk-email-form/BulkEmailForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import {
} from './data/actions';
import { editScheduledEmailThunk, postBulkEmailThunk } from './data/thunks';
import { getScheduledBulkEmailThunk } from '../bulk-email-task-manager/bulk-email-scheduled-emails-table/data/thunks';
import { getDisplayTextFromRecipient } from '../utils';

import './bulkEmailForm.scss';

Expand Down Expand Up @@ -219,7 +220,7 @@ function BulkEmailForm(props) {
<p>{intl.formatMessage(messages.bulkEmailTaskAlertRecipients, { subject: editor.emailSubject })}</p>
<ul className="list-unstyled">
{editor.emailRecipients.map((group) => (
<li key={group}>{group}</li>
<li key={group}>{getDisplayTextFromRecipient(intl, group)}</li>
))}
</ul>
{!isScheduled && (
Expand All @@ -246,7 +247,7 @@ function BulkEmailForm(props) {
<p>{intl.formatMessage(messages.bulkEmailTaskAlertEditingTo)}</p>
<ul className="list-unstyled">
{editor.emailRecipients.map((group) => (
<li key={group}>{group}</li>
<li key={group}>{getDisplayTextFromRecipient(intl, group)}</li>
))}
</ul>
<p>{intl.formatMessage(messages.bulkEmailTaskAlertEditingWarning)}</p>
Expand Down
Loading
Loading