Skip to content

feat!: add design tokens support#224

Merged
brian-smith-tcril merged 7 commits into
masterfrom
master-design-tokens
Jun 18, 2025
Merged

feat!: add design tokens support#224
brian-smith-tcril merged 7 commits into
masterfrom
master-design-tokens

Conversation

@brian-smith-tcril

@brian-smith-tcril brian-smith-tcril commented Apr 11, 2025

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: Pre-design-tokens theming is no longer supported.

LAND AS SQUASH

The master-design-tokens branches were created as long running feature branches to ensure design tokens land on all MFEs simultaneously. These have been kept up to date via merge commits and should land on their respective MFE master branches as a single squashed commit.


@brian-smith-tcril brian-smith-tcril added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Apr 11, 2025
@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@codecov

codecov Bot commented Apr 11, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.02%. Comparing base (f6dfc7f) to head (cc2fb4e).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   84.02%   84.02%           
=======================================
  Files          47       47           
  Lines         695      695           
  Branches      133      136    +3     
=======================================
  Hits          584      584           
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@brian-smith-tcril brian-smith-tcril changed the title master-design-tokens -> master feat!: add design tokens support Jun 18, 2025
@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@brian-smith-tcril brian-smith-tcril marked this pull request as ready for review June 18, 2025 18:59
@brian-smith-tcril brian-smith-tcril merged commit 20ef900 into master Jun 18, 2025
6 checks passed
@brian-smith-tcril brian-smith-tcril deleted the master-design-tokens branch June 18, 2025 19:36
Asespinel pushed a commit to eduNEXT/frontend-app-communications that referenced this pull request Jul 30, 2025
BREAKING CHANGE: Pre-design-tokens theming is no longer supported.

Co-authored-by: Diana Olarte <dcoa@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants