Skip to content

fix: Truncated text in InplaceTextEditor [FC-0090]#2146

Merged
ChrisChV merged 3 commits intoopenedx:masterfrom
open-craft:chris/FAL-4165-fix-truncated-text
Jun 18, 2025
Merged

fix: Truncated text in InplaceTextEditor [FC-0090]#2146
ChrisChV merged 3 commits intoopenedx:masterfrom
open-craft:chris/FAL-4165-fix-truncated-text

Conversation

@ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Jun 14, 2025

Description

  • Fix the truncated text in InplaceTextEditor.
  • Fix the truncated text in the breadcrumbs in the subsection page (ref).
  • Which edX user roles will this change impact? "Course Author".

Supporting information

Testing instructions

  • Go to a library
  • Create a Unit and add some components.
  • Rename the unit with a large name. Open the sidebar and verify that the name is truncated in one line.
  • Rename the names of some components in the unit with large names. On the unit sidebar, verify that the component names are truncated. On the unit page verify that the component names are truncated in one line.
  • Create a Subsection and add some units.
  • Open the subsection page, rename some units with large names. Verify that the names are truncated in one line.
  • Create a Section and add some subsections.
  • Open the section page, rename some subsections with large names. Verify that the names are truncated in one line.

Other information

N/A

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 14, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.08%. Comparing base (b510b6f) to head (260c888).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2146    +/-   ##
========================================
  Coverage   94.08%   94.08%            
========================================
  Files        1164     1164            
  Lines       24491    24491            
  Branches     5195     5328   +133     
========================================
  Hits        23043    23043            
+ Misses       1380     1371     -9     
- Partials       68       77     +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great for the sidebar and titles, but not for the subsection breadcrumbs:

image

Could fixing this be in scope here too?

Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This fixes the issue described, but revealed another issue in the subsection breadcrumbs. Ok to fix this in another PR if that's appropriate?

  • I tested this using the PR test instructions
  • I read through the code and tests
  • I checked for accessibility issues N/A
  • Includes documentation N/A
  • User-facing strings are extracted for translation N/A

@ChrisChV
Copy link
Contributor Author

This fixes the issue described, but revealed another issue in the subsection breadcrumbs. Ok to fix this in another PR if that's appropriate?

Fixed in f445f10

@ChrisChV ChrisChV requested a review from bradenmacdonald June 17, 2025 00:07
@ChrisChV ChrisChV moved this from Needs Triage to Ready to Merge in Contributions Jun 17, 2025
@pomegranited
Copy link
Contributor

Works for me, thank you @ChrisChV !

image

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please don't merge until #2187 has merged.

@ChrisChV ChrisChV enabled auto-merge (squash) June 18, 2025 21:29
@ChrisChV ChrisChV merged commit 97710c2 into openedx:master Jun 18, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Merge to Done in Contributions Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants