fix: Truncated text in InplaceTextEditor [FC-0090]#2146
fix: Truncated text in InplaceTextEditor [FC-0090]#2146ChrisChV merged 3 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2146 +/- ##
========================================
Coverage 94.08% 94.08%
========================================
Files 1164 1164
Lines 24491 24491
Branches 5195 5328 +133
========================================
Hits 23043 23043
+ Misses 1380 1371 -9
- Partials 68 77 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pomegranited
left a comment
There was a problem hiding this comment.
👍 This fixes the issue described, but revealed another issue in the subsection breadcrumbs. Ok to fix this in another PR if that's appropriate?
- I tested this using the PR test instructions
- I read through the code and tests
-
I checked for accessibility issuesN/A -
Includes documentationN/A -
User-facing strings are extracted for translationN/A
Fixed in f445f10 |
|
Works for me, thank you @ChrisChV ! |
bradenmacdonald
left a comment
There was a problem hiding this comment.
LGTM but please don't merge until #2187 has merged.


Description
InplaceTextEditor.Supporting information
Testing instructions
Other information
N/A