Skip to content

Conversation

@navinkarkera
Copy link
Contributor

Description

Removes custom ordering code from course libraries page as it is no longer required once openedx/openedx-platform#36599 is merged.

Useful information to include:

  • Which edX user roles will this change impact? None.

Supporting information

Testing instructions

Verify that sorting behaviour of Review Content Updates tab in course libraries page remains unaffected.
It should sort links based on recently modified downstream components.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 25, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @navinkarkera!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.76%. Comparing base (855b44f) to head (dfce888).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1865      +/-   ##
==========================================
- Coverage   93.77%   93.76%   -0.01%     
==========================================
  Files        1146     1146              
  Lines       23905    23894      -11     
  Branches     5043     5144     +101     
==========================================
- Hits        22416    22405      -11     
  Misses       1421     1421              
  Partials       68       68              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Apr 28, 2025
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 So nice to remove ugly workarounds like this.. thank you @navinkarkera !

  • I tested this by running openedx/openedx-platform#36599 in the backend and making changes to library blocks that are used in a course. Checked that the list of blocks to review is unchanged between this branch and master.
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation N/A
  • User-facing strings are extracted for translation N/A

@bradenmacdonald bradenmacdonald merged commit bc18fff into openedx:master Apr 30, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Apr 30, 2025
@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Apr 30, 2025

Thanks! Please backport to release/teak.master too, unless you think we shouldn't.

@bradenmacdonald bradenmacdonald deleted the navin/use-course-block-modified-time branch April 30, 2025 20:42
navinkarkera added a commit to open-craft/frontend-app-authoring that referenced this pull request May 1, 2025
@navinkarkera
Copy link
Contributor Author

bradenmacdonald pushed a commit that referenced this pull request May 1, 2025
Asespinel pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Jun 11, 2025
DeimerM added a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Sep 16, 2025
* refactor: remove custom order function from course libraries list (openedx#1865) (openedx#1888)

(cherry picked from commit bc18fff)

* perf: use Library search results to populate container card preview [FC-0083] [TEAK] (openedx#1889)

* fix: several library unit page UX bugs (openedx#1868)

* fix: rename "Organize" tab to "Manage"

* fix: duplicate key warnings

* fix: uniform messages while adding to collection

* fix: do not allow units be added to a unit

(cherry picked from commit 0fdc460)

* perf: use Library search results to populate container card preview (openedx#1820)

* fix: use Library search results to populate container card preview

* feat: show published children when showing only published Unit content

* fix: nits

(cherry picked from commit 24e4695)

---------

Co-authored-by: Rômulo Penido <[email protected]>

* fix: manage access modal on duplicated xblock (openedx#1874)

* fix: unit pages ux bugs [FC-0083] (openedx#1884) (openedx#1916)

This PR fixes some UX bugs related to the unit pages:

* Sort for "recently modified" on unit tab does not update after adding new components to units
* Change component delete warning message

It's a backport of openedx#1884

* fix: UX issues in unit page (openedx#1913) (openedx#1923)

Fixes the following issues:

* Selection behavior
* Component selection is by header click only
* Newly created blocks within a unit should be selected on creation/save, appear selected, and have their sidebar open
* Some long text components seem to display at the default height rather than a longer height
* Within the full-page unit view, the "add to collection" overflow menu item on components does not seem to work/only opens the sidebar.
* Draft status indicator text is not vertically centered with icon
* When reordering, dragging a short component past a long component often causes a strange stutter effect.
* When dragging to reorder a component, moving quickly or scrolling often causes the drag handle to be lost / causes the block to jump somewhere else
* Reordering may not consistently support a keyboard-accessible option to change order, like in course authoring
* Tag button on component header opens the old tag side pane

(cherry picked from commit 8c3fab3)

* fix: invalidate search results when publishing all changes in library (openedx#1925) (openedx#1927)

(cherry picked from commit cdb8016)

Co-authored-by: Braden MacDonald <[email protected]>

* fix: improve focus/selected style on library authoring (openedx#1918) (openedx#1930)

Improves the focus and selected styles from the LibraryPage and UnitPage.

* fix: review/sync bugs [FC-0083] (openedx#1905) (openedx#1941)

Fixes issues related to component libraries' review/sync flow

* Inconsistent sync pane title versions
* Library content shown in preview warning only appears in review changes modal when that modal is opened from the review tab
* Some new changes only appear within library review tab on scroll at top of list
* Vertically misaligned sync icon in review changes message on course outline
* Show available updates whenever content is updated, regardless of number of updates available

* fix: Issue with read-only units in libraries & published version of units in library units picker (openedx#1940)

Fixes the issues from openedx#1633 (comment)

* In successfully added units, the "add new component" widget appears sometimes
* In the "add existing unit" modal, the preview shows draft versions of units

* fix: search modal refresh on typing (openedx#1938) (openedx#1948)

* [Teak] backport openedx#1949, openedx#1999 and openedx#2002 (openedx#2006)

* feat: select component and show sidebar on edit  (openedx#1949)

Select component that is being edited in library and show its sidebar. Also fixes issue with children component listing in library unit page

(cherry picked from commit 08ac1c0)

* fix: search text flickering (openedx#1999)

Fix flickering issue in search field.

(cherry picked from commit 6f3b7ab)

* feat: open collection or unit page on double click only (openedx#2002)

Opens collection or unit page only on double click.

(cherry picked from commit 503642b)

* fix: change InplaceTextEditor style and add optimistic update (openedx#1953) (openedx#2014)

* Optimistic update for renaming Components, Collections and Containers
* Change the InplaceTextEditor to show the new text until the onSave promise resolves
* Change the InplaceTextEditor style to: Always show the rename button

* fix: rename library publish button (openedx#2015)

* fix: do open editor of new xblock when duplicating (openedx#2017)

* feat: display editors as modals  (openedx#1838)

* fix: do open editor of new xblock when duplicating (openedx#1887)

Fixes bug where after duplicating an xblock, the editor modal of the old xblock is being open instead of the new copied xblock.

* [Teak] fix: Inconsistent publish status filter menu placement & fix: Remove never published filter from component picker (openedx#2021)

* fix: Inconsistent publish status filter menu placement (openedx#1966)

* fix: Remove never published filter from component picker (openedx#1947)

Removes the never-published filter option from the component picker and unit picker.

* fix: refresh xblock inline after accepting/rejecting library sync (openedx#2022) (openedx#2028)

Instead of reloading the entire Unit after syncing changes from the
library, just reload the xblock that was changed.

(cherry picked from commit ac5574d)

* fix: set maxHeight on TextEditor TinyMce widget [FC-0090] (openedx#2024) (openedx#2030)

Sets a max_height=500px for the TinyMCE editor when editing a Text/Html component.
This prevents the autoresize plugin from expanding the editor textarea beyond the bounds of the editor modal.

⚠️ Because the max height can only be a numeric pixel value, we can't use clever settings like vh or %, and so we're forced to limit the height of the editor to a fixed size for all screen sizes in order to address this issue.

(cherry picked from commit c5f7d0c)

* fix: upstreamInfo is not always provided (openedx#2041) (openedx#2042)

(cherry picked from commit 3fc0f27)

* fix: selection card wiggle (openedx#2047)

* fix: set unit preview readonly on sidebar (openedx#2008) (openedx#2059)

Make the unit preview on the sidebar read-only and add `Truncate` to the `InplaceTextEditor`

* fix: backport changes for html button in text component markdown editor (openedx#2065)

* fix: markdown editor issues in modal (openedx#2076)

This PR resolves rendering issues with the Markdown editor inside the modal.
The problem began after a PR [1] introduced the use of modals for the editor.
The EditorPage [2] component expects a `isMarkdownEditorEnabledForCourse` prop,
which was missing in that implementation.

[1] openedx#1838 
[2] https://github.com/openedx/frontend-app-authoring/pull/1838/files#diff-147218ef88726880178ea895988a5d3feaf2c0c4459086a8de7a4080cbe37de7R226

Backports openedx#2074

* fix: Expand all now expands subsections (openedx#2085)

* fix: files & uploads menu was truncated due to overflow-x (openedx#2071) (openedx#2077)

* fix: (backport) remove an extra editing xblock modal on unit page (openedx#2111) (openedx#2130)

* fix: (backport) enable markdown editor in libraries (openedx#2098)

* fix: enable markdown editor for problems in libraries too

This fix is also achieved on master via 5991fd3 / openedx#2068 but this is a simpler fix, not a direct backport of that refactor.

* fix: remove duplicate markdown_edited save request (openedx#2127)

Removes the unnecessary duplicate save  request of markdown_edited
value to the backend.

Part of: openedx#2099
Backports: 62589ae

---------

Co-authored-by: Muhammad Anas <[email protected]>

* fix: remove icon and empty breadcrumb from libraries (openedx#2129) (openedx#2133)

* fix: (backport) text truncate issue in the search modal (openedx#2151)

* [Teak] fix: published name in unit sidebar in container picker & Issues on Inplace Editor (openedx#2140)

Backport of fix: show unit published name in sidebar on content picker [FC-0090] openedx#2100 
Backport of fix: Issue on the Inplace editor [FC-0090] openedx#2101

* feat: add `v2` `CourseAuthoringUnitSidebarSlot` (openedx#2000)

* fix: advanced-settings api should not camel-case return value (backport) (openedx#2087)

* fix: advanced-settings api should not camel-case return value (openedx#1581)

* fix: update advanced module list not working (openedx#2189)

Backend was still expecting `{'advanced_modules', {'value': ['poll', 'problem-builder', 'h5pxblock']}}` but without this change, it was receiving `{'advancedModules', ['poll', 'problem-builder', 'h5pxblock']}`

Follow up to openedx#1581

---------

Co-authored-by: Muhammad Faraz Maqsood <[email protected]>

* fix: clear selection on files & uploads page after deleting (backport) (openedx#2228)

* refactor: remove selected rows when deleting or adding elements

* refactor: ensure unique asset IDs when adding new ones

* refactor: remove unnecessary loading checks in mockStore function

* test: add unit tests for TableActions component

* fix: loading unit page directly from link after logging in in Teak (openedx#2246)

This is a simple version of the fix for Teak; on master it was fixed with openedx#1867

* fix: pages and resources plugins not rendered (openedx#1885)

* docs: (backport) adding comprehensive readme documentation for plugin slots (openedx#2340)

* fix: publish btn doesn't show after component edit

When we edit & save the component, publish button doesn't show up until we refresh the page manualy or open this unit by opening previous unit and coming back to this unit again.
In this commit, we are dispatching a storage event whenever we edit the component, it'll refresh the page & show the publish button as expected.

---------

Co-authored-by: Navin Karkera <[email protected]>
Co-authored-by: Jillian <[email protected]>
Co-authored-by: Rômulo Penido <[email protected]>
Co-authored-by: Ihor Romaniuk <[email protected]>
Co-authored-by: Braden MacDonald <[email protected]>
Co-authored-by: Chris Chávez <[email protected]>
Co-authored-by: Daniel Valenzuela <[email protected]>
Co-authored-by: Tony Busa <[email protected]>
Co-authored-by: Muhammad Anas <[email protected]>
Co-authored-by: Victor Navarro <[email protected]>
Co-authored-by: diana-villalvazo-wgu <[email protected]>
Co-authored-by: bydawen <[email protected]>
Co-authored-by: Arunmozhi <[email protected]>
Co-authored-by: José Ignacio Palma <[email protected]>
Co-authored-by: Muhammad Faraz Maqsood <[email protected]>
Co-authored-by: Brayan Cerón <[email protected]>
Co-authored-by: Jansen Kantor <[email protected]>
Co-authored-by: Jacobo Dominguez <[email protected]>
Co-authored-by: Muhammad Faraz  Maqsood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants