feat: add plugin slot in authn mfe#1298
Closed
hinakhadim wants to merge 1 commit intoopenedx:masterfrom
Closed
Conversation
Contributor
|
@hinakhadim, we discussed this near the end of today's FWG meeting. What we'll probably do is leverage the loadExternalScripts functionality of frontend-platform to allow any MFE to inject any script they want via configuration, without the need for slots. |
jignaciopm
pushed a commit
to eduNEXT/frontend-app-authn
that referenced
this pull request
Jun 10, 2025
Contributor
|
Closing in favor of openedx/frontend-base#129 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I want to include a React Component or JS file that can read cookies. But it can be done via PluginSlot which is not used in authn MFE. I have included PluginSlot in authn MFE which is wrapping
<Routes>. I was unsure where to include it in authn MFE. I want to include where cookies can be read on any page/route. As all Routes Pages/Components doesn't have same layout, I have to include around `. Feel free to suggest any other way but we have to sure that if I load any page of Authn MFE, code containing "read cookies" should be executed.How Has This Been Tested?
It was tested in dev by passing env.config.jsx. There is one problem I faced is that
@openedx/frontend-plugin-frameworkwas not installing due to deps conflict issue. So I had to install it by force. Because this package has support forreact-error-boundaryv4.x.x and@testing-library/react-hookshas support for error-boundary3.x.x.Merge Checklist
Post-merge Checklist