feat: add parent_course query parameter to basic content-metadata endpoint #1026
+230
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
82
to
83
| # If ``?parent_course=true`` was passed, exclude course runs. | ||
| if self.request.query_params.get('parent_course', False): |
There was a problem hiding this comment.
maybe just "exclude_course_runs" for the parameter name?
There was a problem hiding this comment.
exclude_course_runs suggests the only behavior change is that course runs are excluded. But that is untrue for retrieve(), in which case requested course runs are converted to courses (rather than 404 which is what I'd expect based on the name `exclude_course_runs).
That said, I'm still open to alternative names. Maybe "coerce_to_parent_course"?
pwnage101
force-pushed
the
pwnage101/ENT-9840
branch
2 times, most recently
from
b61c41d to
4118412
Compare
pwnage101
force-pushed
the
pwnage101/ENT-9840
branch
from
0cc5108 to
de1c028
Compare
brobro10000
approved these changes
Jan 22, 2025
Comment on lines
+2222
to
+2284
| @ddt.data(*ddt_cross_product( | ||
| [ | ||
| {'request_content_type': COURSE, 'coerce_to_parent_course': False, 'expect_content_type': COURSE}, | ||
| {'request_content_type': COURSE, 'coerce_to_parent_course': True, 'expect_content_type': COURSE}, | ||
| {'request_content_type': COURSE_RUN, 'coerce_to_parent_course': False, 'expect_content_type': COURSE_RUN}, | ||
| {'request_content_type': COURSE_RUN, 'coerce_to_parent_course': True, 'expect_content_type': COURSE}, | ||
| ], | ||
| # Repeat ever test above given different types of identifier input types. | ||
| [ | ||
| {'request_by_field': 'id'}, | ||
| {'request_by_field': 'content_key'}, | ||
| {'request_by_field': 'content_uuid'}, | ||
| ], | ||
| )) |
There was a problem hiding this comment.
Very cool implementation, if I am understanding correctly, this ends up being 12 test cases total?
pwnage101
force-pushed
the
pwnage101/ENT-9840
branch
from
de1c028 to
ac3b5e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENT-9840