-
Notifications
You must be signed in to change notification settings - Fork 78
docs: initial setup for pdf block #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,92 @@ | ||||||
| .. _Add Embedded PDF: | ||||||
|
|
||||||
| ############################## | ||||||
| Embedding PDFs in Your Course | ||||||
|
||||||
| Embedding PDFs in Your Course | |
| Embed PDFs in Your Course |
Just a nit. How to articles should start with a phrase that follows "How To" (eg, "How To Embed..." not "How To Embedding..."). Could (should?) also be "Add Embedded PDF" to match the ref link at line 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would generally apply this fix and then merge this, but I don't have permissions on this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarina I've pushed a change which applies this suggestion and also relabels a lower header to be 'How to [...]'. Let me know if this is what you meant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this would be a more useful screenshot if it included some of the Studio UI (eg. with the edit button, etc.). That might provide some more context, especially for where it's used to demonstrate what it should look like once you've selected the pdf component to add in studio.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kelketek did you have thoughts on this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samuelallan72 I missed the original comment, but I don't think this should be changed as it matches how screenshots are handled in other parts of the documentation, like here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, that's fair. Thanks for checking. :)