Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

fix: Upgrade CLI checks to Mac>10 #956

Merged
merged 3 commits into from
Aug 10, 2022
Merged

fix: Upgrade CLI checks to Mac>10 #956

merged 3 commits into from
Aug 10, 2022

Conversation

johnnagro
Copy link
Contributor

@johnnagro johnnagro commented Aug 10, 2022 •
edited
Loading

Description

  • need to upgrade to a newer mac runner image
  • virtualbox issues + docker-machine is no longer maintained
  • switching to lima https://github.com/lima-vm/lima
  • pre-pull the redis image used in testing, probably should move into test setup

References

@johnnagro johnnagro marked this pull request as ready for review August 10, 2022 18:13
@johnnagro johnnagro requested review from rgraber and timmc-edx and removed request for rgraber August 10, 2022 18:13
timmc-edx
timmc-edx approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@timmc-edx timmc-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! I have a couple of suggestions, but you can merge when ready.

@johnnagro johnnagro requested a review from timmc-edx August 10, 2022 19:02
@johnnagro johnnagro merged commit 4aa2959 into master Aug 10, 2022
@johnnagro johnnagro deleted the jnagro/BOM-3486/0 branch August 10, 2022 19:57
nsprenkle pushed a commit that referenced this pull request Nov 21, 2023
@johnnagro @nsprenkle
fix: Upgrade CLI checks to Mac>10 (#956)
874d4a1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timmc-edx timmc-edx timmc-edx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnnagro @timmc-edx