Cherry-pick #182 and #183 to release/4.1 branch #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sources This is added as a top-level `labels` map within the values file. If it is populated, these labels will be added to the storageclass. It is also added to the 'localpv.labels' variable, already included within every resource besides the storageclass. Signed-off-by: Andrew Lavery <[email protected]> Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Bernard Gütermann <[email protected]> Signed-off-by: Niladri Halder <[email protected]>
…ll chart resources Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>
niladrih
requested review from
tiagolobocastro,
avishnu,
Abhinandan-Purkait and
dsharma-dc
Signed-off-by: Niladri Halder <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release/4.1 #231 +/- ##
==============================================
Coverage ? 29.47%
==============================================
Files ? 1
Lines ? 699
Branches ? 0
==============================================
Hits ? 206
Misses ? 488
Partials ? 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tiagolobocastro
approved these changes
Jan 22, 2025
dsharma-dc
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: