ci: migrate from deprecated attest wrappers to actions/attest - #152
Merged
Conversation
actions/attest-sbom and actions/attest-build-provenance are deprecated and today are thin wrappers around actions/attest, so this just cuts out the middleman. Inputs are identical (subject-name, subject-digest, sbom-path, push-to-registry), the attestation type is picked from the inputs -> sbom-path gives an SBOM attestation, no sbom-path gives SLSA build provenance. Pinned to 1e69f48 (v4 / v4.2.2). Same change as solution-arsenal#759 and artifact-conduit#460.
create-storage-record defaults to true whenever push-to-registry is set, so every attest step tries it and every one of them fails with "Failed to persist storage record: no artifacts found". Thats 2 warnings per image, 4 per build here, and it has never once succeeded. Storage records only feed the org Linked Artifacts page, which we dont use. The attestations themselves are unaffected, they still land in the repo and get pushed to ghcr. The error is not an auth failure either, the "check the artifact-metadata:write permission" hint the action prints after it is unconditional and the org check already passes -> adding that permission would be a guess.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Every other pin in this repo carries the full vX.Y.Z, 29 of 29, so a bare "# v4" was the odd one out. The SHA is what actually pins it, but the comment is what people read.
BergCyrill
approved these changes
Aug 20, 2026
BergCyrill
left a comment
BergCyrill
left a comment
Contributor
There was a problem hiding this comment.
Validated attestations (provenance & sbom) and digest - lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Same change as opendefensecloud/solution-arsenal#759 and opendefensecloud/artifact-conduit#460, applied here. Full reasoning is over there, i wont copy it.
docker.yaml: Attest SBOM + Attest provenance ->actions/attest, pinned1e69f48(v4 / v4.2.2)create-storage-record: falseon both stepsWhy
actions/attest-sbomandactions/attest-build-provenanceare deprecated and today just shell out toactions/attestanyway, so this cuts out the middleman before the wrappers go away.Testing
Locally:
actionlintclean on the changed file, 0 findings.The upstream twin PRs are verified end to end, an
ok-to-imagerun there was green on all 8 images with 0 warnings in the attest steps, and the attestations verify independently viagh attestation verifyagainst Rekor for bothhttps://slsa.dev/provenance/v1andhttps://cyclonedx.org/bom.Not yet verified in this repo. Needs an
ok-to-imagerun before merge:Attestation uploaded to repository+to registryon both steps, 4/4attest-sbom has been deprecatedwarningFailed to create storage recordwarningsNotes for reviewers
Workflows only, no CRD/API/RBAC. Dont squash blindly, commit 1 is behavior-neutral and commit 2 is not.
Ref opendefensecloud/odd-internal#75