Skip to content

Conversation

@Amli
Copy link
Contributor

@Amli Amli commented Feb 26, 2025

  • prepare-version.sh sets up the environment based on targeted ES version
  • build.sh just run gradlew in a docker container

It also adds a github action workflows to run the build and tests.

Next steps would be to:

  • replicate this on the other plugin repository
  • automate releases

@Amli Amli requested review from 5k4nd and garaud February 26, 2025 10:35
5k4nd added 2 commits March 20, 2025 13:35
- `prepare-version.sh`` sets up the environment based on targeted ES version
- `build.sh` just run gradlew in a docker container

It also adds a github action workflows to run the build and tests.
@5k4nd 5k4nd force-pushed the automate-builds-first-step branch from 7a3ce41 to 62cb4d8 Compare March 20, 2025 12:39
Copy link
Contributor

@5k4nd 5k4nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just fixed a small Dockerfile issue preventing from starting the daemon, otherwise it works like a charm, thank you @Amli

I changed the .env file to point to the current master version, hence we can merge in this state after @garaud approval.

@5k4nd 5k4nd marked this pull request as ready for review March 20, 2025 12:43
@5k4nd 5k4nd force-pushed the automate-builds-first-step branch from 88a37cf to dacba55 Compare March 20, 2025 12:46
@garaud
Copy link
Contributor

garaud commented Mar 21, 2025

Tested locally. Works well. Thanks for this job!

I might be possible with the ./prepare-version.sh to get the pathhierarchy-aggregation-x.y.z.zip in the local build/distributions folder? Or add a sentence to the README file to explain how we can retrieve this file from the container.

Copy link
Contributor

@garaud garaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well, thank you!

@Amli
Copy link
Contributor Author

Amli commented Mar 25, 2025

I might be possible with the ./prepare-version.sh to get the pathhierarchy-aggregation-x.y.z.zip in the local build/distributions folder? Or add a sentence to the README file to explain how we can retrieve this file from the container.

@garaud I changed the README a bit to process more accurate, it was not up to date 🙏

@Amli Amli merged commit 06fc00f into master Mar 25, 2025
1 check passed
@Amli Amli deleted the automate-builds-first-step branch March 25, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants