-
Notifications
You must be signed in to change notification settings - Fork 215
feat(RHOAIENG-35050): add support to pass Garak KFP image for downstream #2567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2567 +/- ##
=======================================
Coverage 47.43% 47.43%
=======================================
Files 146 146
Lines 13188 13188
=======================================
Hits 6256 6256
Misses 6408 6408
Partials 524 524 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@ruivieira is this still something for 3.0? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
close this one as it wont be needed for 3.0 |
Description
This PR implements image replacement for the
garak-provider-imageparameter in the TrustyAI operator.Related JIRAs and PRs:
Merge criteria
E2E test suite update requirement
When bringing new changes to the operator code, such changes are by default required to be accompanied by extending and/or updating the E2E test suite accordingly.
To opt-out of this requirement:
E2E update requirement opt-out justificationsection belowE2E update requirement opt-out justification
Small change