Skip to content

feat(RHOAIENG-35049): add support to pass RAGAS KFP image for downstream #2566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Oct 16, 2025
Merged

feat(RHOAIENG-35049): add support to pass RAGAS KFP image for downstream #2566

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6107fa4
feat(RHOAIENG-35049): add support to pass RAGAS KFP image for downstream
ruivieira Sep 29, 2025
c4d7e7f
Merge branch 'main' into RHOAIENG-35049-ragas
zdtsw Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/controller/components/trustyai/trustyai_support.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ var (
"guardrails-orchestrator-image": "RELATED_IMAGE_ODH_FMS_GUARDRAILS_ORCHESTRATOR_IMAGE",
"guardrails-sidecar-gateway-image": "RELATED_IMAGE_ODH_TRUSTYAI_VLLM_ORCHESTRATOR_GATEWAY_IMAGE",
"guardrails-built-in-detector-image": "RELATED_IMAGE_ODH_BUILT_IN_DETECTOR_IMAGE",
"ragas-provider-image": "RELATED_IMAGE_ODH_TRUSTYAI_RAGAS_PROVIDER_IMAGE",
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify parameter and environment variable names.

The addition follows the existing pattern and naming conventions correctly. However, please ensure:

  1. The parameter name ragas-provider-image matches what the TrustyAI operator expects (as referenced in the linked trustyai-service-operator PR ODH Release 1.10 for operator v1.10.0 #565).
  2. The environment variable RELATED_IMAGE_ODH_TRUSTYAI_RAGAS_PROVIDER_IMAGE is defined in the build/deployment configuration.

Run the following script to verify the environment variable is referenced elsewhere in the codebase:

🏁 Script executed:

#!/bin/bash
# Description: Verify that RELATED_IMAGE_ODH_TRUSTYAI_RAGAS_PROVIDER_IMAGE is defined or used in other files

# Search for the environment variable definition in Dockerfiles, manifests, or config files
rg -nC3 'RELATED_IMAGE_ODH_TRUSTYAI_RAGAS_PROVIDER_IMAGE'

# Search for references to ragas-provider-image parameter
rg -nC3 'ragas-provider-image'

Length of output: 1793

Define RELATED_IMAGE_ODH_TRUSTYAI_RAGAS_PROVIDER_IMAGE and validate parameter consumption.

  • RELATED_IMAGE_ODH_TRUSTYAI_RAGAS_PROVIDER_IMAGE isn’t defined or referenced in any Dockerfile, manifest, or config; add it to your build/deployment configuration.
  • Ensure the TrustyAI operator actually consumes the ragas-provider-image parameter as expected.
🤖 Prompt for AI Agents 
In internal/controller/components/trustyai/trustyai_support.go around line 32,
the map entry for "ragas-provider-image" references
RELATED_IMAGE_ODH_TRUSTYAI_RAGAS_PROVIDER_IMAGE which is not defined or
consumed; add that RELATED_IMAGE_* key to your build/deployment configuration
(e.g., Dockerfile/Makefile image export, operator bundle CSV/annotations, and
kustomize/helm values) so it becomes available as an environment variable in the
running pod, and then ensure the TrustyAI operator actually consumes it by
wiring the env var into the operator Deployment/Pod spec (or reading it in code
where images are resolved) so the ragas-provider-image parameter is used when
constructing the provider image reference. Ensure the same variable name is
listed in bundle/CSV RELATED_IMAGE annotations, in the image build/export
pipeline, and mapped into the container env or args so the operator uses it at
runtime.

"oauthProxyImage": "RELATED_IMAGE_OSE_OAUTH_PROXY_IMAGE",
"kube-rbac-proxy": "RELATED_IMAGE_OSE_KUBE_RBAC_PROXY_IMAGE",
}
Expand Down
Loading