Adding Fastcv extension for normalizeLocalBox u8 and f32 #3916
+70
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorkalov
reviewed
Apr 2, 2025
Comment on lines
+68
to
+69
| * @param src Input image, should have one channel CV_8U or CV_32F | ||
| * @param dst Output array, should be one channel, CV_8S if src of type CV_8U, or CV_32F if src of CV_32F |
There was a problem hiding this comment.
Documentation and parameters name do not match.
Comment on lines
+143
to
+148
| while (next()) | ||
| { | ||
| startTimer(); | ||
| cv::fastcv::normalizeLocalBox(src, dst, sz, useStdDev); | ||
| stopTimer(); | ||
| } |
There was a problem hiding this comment.
OCL_TEST_CYCLE() does the loop for you.
Example:
OCL_TEST_CYCLE() cv::fastcv::normalizeLocalBox(src, dst, sz, useStdDev);
| * @param pSize Patch size for mean and std dev calculation | ||
| * @param useStdDev If 1, bot mean and std dev will be used for normalization, if 0, only mean used | ||
| */ | ||
| CV_EXPORTS_W void normalizeLocalBox(InputArray _src, OutputArray _dst, Size pSize, bool useStdDev); |
There was a problem hiding this comment.
Some accuracy test would be useful too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fastcv extension for normalizeLocalBox u8 and f32
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.