curvefs/metaserver: fix trash bugs #2942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuhongsong
force-pushed
the
fix_trash.12.01
branch
2 times, most recently
from
9f5ead3 to
10e5d20
Compare
|
cicheck |
wuhongsong
force-pushed
the
fix_trash.12.01
branch
from
10e5d20 to
dc5b193
Compare
|
cicheck |
|
cicheck |
1 similar comment
|
cicheck |
wuhongsong
force-pushed
the
fix_trash.12.01
branch
2 times, most recently
from
8b7ef4b to
2c618ca
Compare
|
cicheck |
wuhongsong
force-pushed
the
fix_trash.12.01
branch
from
2c618ca to
881ab9a
Compare
|
cicheck |
wuhongsong
force-pushed
the
fix_trash.12.01
branch
from
881ab9a to
75856a4
Compare
wuhongsong
force-pushed
the
fix_trash.12.01
branch
from
75856a4 to
e3b33a4
Compare
wuhongsong
force-pushed
the
fix_trash.12.01
branch
from
e3b33a4 to
dff11ec
Compare
SeanHai
reviewed
Dec 4, 2023
| @@ -312,7 +312,7 @@ MetaStatusCode InodeManager::DeleteInode(uint32_t fsId, uint64_t inodeId, | |||
| MetaStatusCode InodeManager::UpdateInode(const UpdateInodeRequest& request, | |||
| int64_t logIndex) { | |||
| CHECK_APPLIED(); | |||
| VLOG(9) << "update inode, fsid: " << request.fsid() | |||
| VLOG(0) << "update inode, fsid: " << request.fsid() | |||
| --(*type2InodeNum_)[old.type()]; | ||
| } | ||
|
|
||
| VLOG(0) << "UpdateInode success, " << request.ShortDebugString(); |
| @@ -187,6 +198,11 @@ class InodeStorage { | |||
| MetaStatusCode GetAllBlockGroup( | |||
| std::vector<DeallocatableBlockGroup>* deallocatableBlockGroupVec); | |||
|
|
|||
| /* | |||
| std::shared_ptr<KVStorage> GetKVStorage() { | |||
| @@ -92,6 +95,13 @@ class RocksDBStorage : public KVStorage, public StorageTransaction { | |||
| const std::string& key, | |||
| const ValueType& value) override; | |||
|
|
|||
| Status HSetDeleting(const std::string& name, | |||
There was a problem hiding this comment.
The interfaces added is unnecessary, rocksdb_storage only need the most basic interface, and you should deal the logic upper layer
| MetaStatusCode InodeStorage::UpdateDeletingKey( | ||
| const Inode& inode, int64_t logIndex) { | ||
| WriteLockGuard lg(rwLock_); | ||
| Key4Inode key(inode.fsid(), inode.inodeid()); |
There was a problem hiding this comment.
Here you can add a new struct like Key4DeletedInode in which you can add deleted prefix before inode key
| @@ -43,6 +43,7 @@ | |||
| #include "curvefs/src/metaserver/storage/utils.h" | |||
| #include "src/common/concurrent/rw_lock.h" | |||
|
|
|||
| #define DELETING_PREFIX "deleting_" | |||
There was a problem hiding this comment.
The raw string prefix is inappropriate, you can add a new key type in
| LOG(ERROR) << "Begin transaction failed"; | ||
| return MetaStatusCode::STORAGE_INTERNAL_ERROR; | ||
| } | ||
| auto rc = txn->HSetDeleting(table4Inode_, skey , inode); |
There was a problem hiding this comment.
The dtime as the value set to rocksdb is enough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List