curve bs list snapshot #2844
Merged
curve bs list snapshot #2844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cicheck |
|
call for review |
caoxianfei1
approved these changes
Oct 30, 2023
|
LGTM! |
Cyber-SiKu
reviewed
Oct 30, 2023
| @@ -142,6 +142,8 @@ const ( | |||
| VIPER_CURVEBS_DEST = "curvebs.dest" | |||
| CURVEBS_TASKID = "taskid" | |||
| VIPER_CURVEBS_TASKID = "curvebs.taskid" | |||
| CURVEBS_SNAPSHOT_ID = "snapshotid" | |||
| VIPER_CURVEBS_SNAPSHOT_ID = "curvebs.snapshotqid" | |||
There was a problem hiding this comment.
option flag need default value
|
cicheck |
|
@ZackSoul squash to one commit. |
Cyber-SiKu
approved these changes
Oct 30, 2023
Signed-off-by: 了阔以 <[email protected]> add the default value Signed-off-by: 了阔以 <[email protected]>
ZackSoul
force-pushed
the
bs-list-snapshot
branch
from
a190513 to
5c79770
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2832
Problem Summary:
What is changed and how it works?
add bs list snapshot command
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List