[feat]tools-v2: improve the snapshot tool #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cicheck |
|
cicheck |
1 similar comment
|
cicheck |
Cyber-SiKu
reviewed
Oct 12, 2023
tools-v2/pkg/cli/command/curvebs/delete/volume/recover/recover.go
Outdated
Show resolved
Hide resolved
Cyber-SiKu
approved these changes
Oct 12, 2023
|
cicheck |
|
cicheck |
2 tasks
|
cicheck |
2 similar comments
|
cicheck |
|
cicheck |
|
cicheck |
1 similar comment
|
cicheck |
|
@baytan0720 need to rebase and fix conflict. |
baytan0720
force-pushed
the
util
branch
2 times, most recently
from
3e7691e to
51b1936
Compare
|
cicheck |
Signed-off-by: baytan0720 <[email protected]>
|
cicheck |
|
cicheck |
caoxianfei1
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
define Response, SnapshotInfo, TaskInfo and there's field
add more error descriptions
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List