fix(util): stop write log to stderr, when FLAGS_logtostderr is false

Signed-off-by: NaturalSelect <[email protected]>
opencurve · Nov 7, 2023 · dd58873 · dd58873
1 parent 09d2f02
commit dd58873
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 48 deletions.
diff --git a/curvefs/src/mds/main.cpp b/curvefs/src/mds/main.cpp
@@ -25,7 +25,6 @@
 
 #include "curvefs/src/mds/mds.h"
 #include "src/common/configuration.h"
-#include "src/common/log_util.h"
 #include "curvefs/src/common/dynamic_vlog.h"
 
 using ::curve::common::Configuration;
@@ -65,8 +64,8 @@ int main(int argc, char **argv) {
     }
 
     // initialize logging module
-    FLAGS_logtostderr = false;
-    curve::common::InitGoogleLogging(argv[0]);
+    FLAGS_stderrthreshold = 3;
+    google::InitGoogleLogging(argv[0]);
 
     conf->PrintConfig();
 

diff --git a/src/chunkserver/chunkserver.cpp b/src/chunkserver/chunkserver.cpp
@@ -105,8 +105,8 @@ int ChunkServer::Run(int argc, char** argv) {
     LoadConfigFromCmdline(&conf);
 
     // 初始化日志模块
-    FLAGS_logtostderr = false;
-    curve::common::InitGoogleLogging(argv[0]);
+    FLAGS_stderrthreshold = 3;
+    google::InitGoogleLogging(argv[0]);
 
     // 打印参数
     conf.PrintConfig();

diff --git a/src/common/log_util.cpp b/src/common/log_util.cpp
diff --git a/src/common/log_util.h b/src/common/log_util.h
diff --git a/src/mds/main/main.cpp b/src/mds/main/main.cpp
@@ -107,8 +107,8 @@ int main(int argc, char **argv) {
     }
 
     // initialize logging module
-    FLAGS_logtostderr = false;
-    curve::common::InitGoogleLogging(argv[0]);
+    FLAGS_stderrthreshold = 3;
+    google::InitGoogleLogging(argv[0]);
 
     // reset SIGPIPE handler
     // etcdclient register SIGPIPE handler in its initialization progress, which

diff --git a/src/snapshotcloneserver/main.cpp b/src/snapshotcloneserver/main.cpp
@@ -22,7 +22,6 @@
 #include <glog/logging.h>
 #include <gflags/gflags.h>
 #include "src/snapshotcloneserver/snapshotclone_server.h"
-#include "src/common/log_util.h"
 
 DEFINE_string(conf, "conf/snapshot_clone_server.conf", "snapshot&clone server config file path");  //NOLINT
 DEFINE_string(addr, "127.0.0.1:5555", "snapshotcloneserver address");
@@ -81,8 +80,8 @@ int main(int argc, char **argv) {
     LoadConfigFromCmdline(conf.get());
     conf->PrintConfig();
     conf->ExposeMetric("snapshot_clone_server_config");
-    FLAGS_logtostderr = false;
-    curve::common::InitGoogleLogging(argv[0]);
+    FLAGS_stderrthreshold = 3;
+    google::InitGoogleLogging(argv[0]);
     snapshotcloneserver_main(conf);
 }