add more test cases

Signed-off-by: Ziy1-Tan <[email protected]>
opencurve · Nov 17, 2023 · 65533bd · 65533bd
1 parent 78e2343
commit 65533bd
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 11 deletions.
diff --git a/src/common/string_util.h b/src/common/string_util.h
@@ -176,7 +176,7 @@ inline void LTrim(std::string &s) {
 // trim from end (in place)
 inline void RTrim(std::string &s) {
   s.erase(std::find_if(s.rbegin(), s.rend(),
-                       [](const char &c) { return !std::isspace(c); })
+                       [](const char &ch) { return !std::isspace(ch); })
               .base(),
           s.end());
 }

diff --git a/test/common/string_util_test.cpp b/test/common/string_util_test.cpp
@@ -60,36 +60,44 @@ TEST(Common, StringToUll) {
     ASSERT_FALSE(StringToUll(str, &out));
 }
 
-TEST(StringUtilTest, ltrim) {
+TEST(StringUtilTest, LTrim) {
   std::array<std::array<std::string, 2>, 4> cases = {
-      std::array<std::string, 2>{"hello", "hello"},
-      std::array<std::string, 2>{"", ""}, std::array<std::string, 2>{"  ", ""},
-      std::array<std::string, 2>{"  hello", "hello"}};
+    std::array<std::string, 2>{"hello", "hello"},
+    std::array<std::string, 2>{"", ""},
+    std::array<std::string, 2>{"  ", ""},
+    std::array<std::string, 2>{"  hello", "hello"},
+  };
 
   for (auto &c : cases) {
     curve::common::LTrim(c[0]);
     EXPECT_EQ(c[0], c[1]);
   }
 }
 
-TEST(StringUtilTest, rtrim) {
+TEST(StringUtilTest, RTrim) {
   std::array<std::array<std::string, 2>, 4> cases = {
-      std::array<std::string, 2>{"hello", "hello"},
-      std::array<std::string, 2>{"", ""}, std::array<std::string, 2>{"  ", ""},
-      std::array<std::string, 2>{"hello  ", "hello"}};
+    std::array<std::string, 2>{"hello", "hello"},
+    std::array<std::string, 2>{"", ""},
+    std::array<std::string, 2>{"  ", ""},
+    std::array<std::string, 2>{"hello  ", "hello"},
+  };
 
   for (auto &c : cases) {
     curve::common::RTrim(c[0]);
     EXPECT_EQ(c[0], c[1]);
   }
 }
 
-TEST(StringUtilTest, trim) {
-  std::array<std::array<std::string, 2>, 6> cases = {
+TEST(StringUtilTest, Trim) {
+  std::array<std::array<std::string, 2>, 10> cases = {
       std::array<std::string, 2>{"hello", "hello"},
       std::array<std::string, 2>{"   hello", "hello"},
       std::array<std::string, 2>{"hello    ", "hello"},
       std::array<std::string, 2>{"    hello  ", "hello"},
+      std::array<std::string, 2>{"S3 Browser", "S3 Browser"},
+      std::array<std::string, 2>{"S3 Browser  ", "S3 Browser"},
+      std::array<std::string, 2>{"   S3 Browser", "S3 Browser"},
+      std::array<std::string, 2>{" S3 Browser  ", "S3 Browser"},
       std::array<std::string, 2>{"    ", ""},
       std::array<std::string, 2>{"", ""},
   };