Skip to content

Update allocationReport.js #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update allocationReport.js #81

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f079b37
Update allocationReport.js
JORDAN-RYAN1 Apr 28, 2025
1ec2d6d
Merge branch 'main' into patch-1
ameijer Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/components/allocationReport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,14 @@ function stableSort(array, comparator) {
return stabilizedThis.map((el) => el[0]);
}

// ✅ Helper function to build display name with namespace
function getDisplayName(row) {
if (row.namespace) {
return `${row.namespace}:${row.name}`;
}
return row.name;
}

const headCells = [
{ id: "name", numeric: false, label: "Name", width: "auto" },
{ id: "cpuCost", numeric: true, label: "CPU", width: 90 },
Expand Down Expand Up @@ -159,6 +167,7 @@ const AllocationReport = ({
);
})}
</TableRow>

{pageRows.map((row, key) => {
if (row.name === "__unmounted__") {
row.name = "Unmounted PVs";
Expand All @@ -178,11 +187,10 @@ const AllocationReport = ({
efficiency = "Inf";
}

// Do not allow drill-down for idle and unallocated rows
if (isIdle || isUnallocated || isUnmounted) {
return (
<TableRow key={key}>
<TableCell align="left">{row.name}</TableCell>
<TableCell align="left">{getDisplayName(row)}</TableCell>
<TableCell align="right">
{toCurrency(row.cpuCost, currency)}
</TableCell>
Expand All @@ -209,7 +217,7 @@ const AllocationReport = ({

return (
<TableRow key={key}>
<TableCell align="left">{row.name}</TableCell>
<TableCell align="left">{getDisplayName(row)}</TableCell>
<TableCell align="right">
{toCurrency(row.cpuCost, currency)}
</TableCell>
Expand Down