Conversation
There was a problem hiding this comment.
Pull request overview
Adds “external data” support to OpenCOR’s interactive simulation/plotting flow by extending the UI JSON schema/model and wiring CSV import + expression-based VOI transforms into the interactive plotting pipeline (Fixes #452).
Changes:
- Extend UI JSON output to include
externalData(schema + validation), and expose types vialocApi. - Add UI to import/configure external CSV data (file/URL) and use it in interactive plots with VOI expressions + interpolation.
- Update math/expression tooling and bump build tooling dependencies (Vite/Electron/etc).
Reviewed changes
Copilot reviewed 29 out of 37 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/data/tt04_V_with_skipped_time_data_points_and_noise.csv | Adds external-data fixture CSV with noise/skipped points. |
| tests/data/tt04_V_with_skipped_time_data_points.csv | Adds external-data fixture CSV without noise. |
| tests/data/not_a_csv_file.csv | Adds negative fixture for CSV parsing. |
| tests/data/no_voi_header.csv | Adds negative fixture for missing VOI header. |
| tests/data/no_data_series.csv | Adds negative fixture for missing data series columns. |
| tests/data/no_data_header.csv | Adds negative fixture for missing data header name. |
| tests/data/invalid_data.csv | Adds negative fixture for non-numeric value. |
| tests/data/duplicate_headers.csv | Adds negative fixture for duplicate data headers. |
| tests/data/different_number_data_series.csv | Adds negative fixture for inconsistent row column counts. |
| src/renderer/vite.lib.config.ts | Removes optimizeDeps.esbuildOptions.target. |
| src/renderer/vite.config.ts | Removes optimizeDeps.esbuildOptions.target. |
| electron.vite.config.ts | Removes optimizeDeps.esbuildOptions.target. |
| src/renderer/src/libopencor/locUiJsonApi.ts | Adds externalData UI JSON types + validation enhancements (incl. expression parsing and options). |
| src/renderer/src/libopencor/locApi.ts | Re-exports new UI JSON external-data types. |
| src/renderer/src/libopencor/locSedApi.ts | Minor string formatting cleanup in issue messages. |
| src/renderer/src/components/widgets/InputScientificNumber.vue | Minor paste parsing check simplification. |
| src/renderer/src/components/widgets/GraphPanelWidget.vue | Uses new math.FloatArray type for trace arrays. |
| src/renderer/src/components/views/SimulationExperimentView.vue | Implements external-data mapping, VOI expression evaluation, interpolation, and plot-expression evaluation updates. |
| src/renderer/src/components/dialogs/SimulationExperimentViewSettingsDialog.vue | Adds “External data” tab, CSV import (file/URL), and external data configuration UI. |
| src/renderer/src/components/dialogs/BaseDialog.vue | Minor numeric-to-string formatting cleanup. |
| src/renderer/src/components/OpenCORToast.ts | Adds provide/inject wrapper for toast usage from nested components. |
| src/renderer/src/components/OpenCOR.vue | Provides toast injection and minor variable rename in GitHub auth flow. |
| src/renderer/src/common/math.ts | Adds FloatArray alias, extends supported trig functions, and adds symbol allow-list enforcement. |
| src/renderer/src/common/locCommon.ts | Minor string formatting cleanup in fetch error messages. |
| src/renderer/src/common/constants.ts | Minor string formatting cleanup for copyright. |
| src/renderer/src/common/common.ts | Minor string formatting cleanup in formatTime. |
| src/renderer/scripts/dependencies.update.js | Minor variable rename (result → res). |
| package.json | Version bump + dependency bumps (Electron/Vite/etc). |
| bun.lock | Lockfile updates for dependency bumps. |
| src/renderer/package.json | Renderer version bump + dependency bumps. |
| src/renderer/bun.lock | Renderer lockfile updates for dependency bumps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/renderer/src/components/dialogs/SimulationExperimentViewSettingsDialog.vue
Outdated
Show resolved
Hide resolved
src/renderer/src/components/dialogs/SimulationExperimentViewSettingsDialog.vue
Outdated
Show resolved
Hide resolved
513e3ea to
f85eada
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 38 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 38 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/renderer/src/components/dialogs/SimulationExperimentViewSettingsDialog.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 38 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes #452.