Skip to content

config-linux: add SHOULD to linux.namespaces.type #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhouhao3 wants to merge 2 commits into from
Closed

config-linux: add SHOULD to linux.namespaces.type #931

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81d7ec4
config-linux: add SHOULD to linux.namespaces.type
Oct 18, 2017
179623f
Merge branch 'master' into namespecs-fix
vbatts Dec 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config-linux.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ For more information, see the [namespaces(7)][namespaces.7_2] man page.
Namespaces are specified as an array of entries inside the `namespaces` root field.
The following parameters can be specified to set up namespaces:

* **`type`** *(string, REQUIRED)* - namespace type. The following namespace types are supported:
* **`type`** *(string, REQUIRED)* - namespace type. The following namespace types SHOULD be supported:
Copy link
Contributor

@wking wking Oct 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the runtime-spec PR, you're claiming a config validation, but the "supported" language here sounds like it targets the runtime. How about:

Configuration SHOULD use, and runtimes SHOULD support, the following types:

Personally, I'd prefer MUSTing runtime support (more in #813), but even SHOULD would better than the current lack of RFC 2119 language.

* **`pid`** processes inside the container will only be able to see other processes inside the same container.
* **`network`** the container will have its own network stack.
* **`mount`** the container will have an isolated mount table.
Expand Down