adds client api integration tests for runc using bash w/bats #659
Conversation
|
@mikebrow simply amazing!. |
|
Looks great! Thanks @mikebrow |
mikebrow
force-pushed
the
integration-test-bats
branch
2 times, most recently
from
2dde64e to
64c0bab
Compare
|
Looks great. I reckon we should also add some tests making sure that resource limiting actually works (it was broken a few times in the past and nobody noticed until someone tried to vendor it into Docker). |
|
Ayup.. next on my list was actually going to be stress & bootstrap tests.. like constraint checking. First one I started writing I found a bug :-) |
mikebrow
force-pushed
the
integration-test-bats
branch
from
64c0bab to
0a0b04b
Compare
|
rebased on current master... |
|
LGTM |
|
We should add this to the Jenkins test jobs. Aside from my point about the Dockerfile, LGTM. |
| --no-install-recommends | ||
|
|
||
| # install bats | ||
| RUN cd /tmp \ |
There was a problem hiding this comment.
We should specify an exact commit or version in the repo to checkout. This means that we don't have to worry about inconsistencies in the test framework. Please also strip the trailing whitespace.
There was a problem hiding this comment.
removed the trailing whitespace from this file... Per Michael's comment leaving the which/how of picking or caching a particular version of bats for another PR.
There was a problem hiding this comment.
I think he meant "we should add it to the Jenkins jobs in another PR". I don't like pulling in the latest version of bats from HEAD when doing testing -- that doesn't strike me as being a particularly good idea.
There was a problem hiding this comment.
kk... np... updated to reset head back to a known commit (which is the latest atm).
Cheers.
|
ya, we can add that in another pr |
mikebrow
force-pushed
the
integration-test-bats
branch
from
0a0b04b to
7f79dcc
Compare
|
Rebased... comment addressed. |
Signed-off-by: Mike Brown <[email protected]>
mikebrow
force-pushed
the
integration-test-bats
branch
from
7f79dcc to
e9f89e1
Compare
|
Comments addressed. |
|
LGTM. |
6 participants
Closes issue #485
See readme.md for usage instructions.
Signed-off-by: Mike Brown [email protected]