Do not use stream encoders for pipe communication #515
Conversation
libcontainer/utils/utils.go
Outdated
There was a problem hiding this comment.
would be nice to have the returned length and expected value here, something like: fmt.Errorf("object not written, got(%d), expected(%d)", n, len(data))
|
I think having a separate pipe for sync would significantly simplify the code. But for now, this code is fine. |
crosbymichael
force-pushed
the
readall
branch
from
bd53ea9 to
bc4612d
Compare
libcontainer/utils/utils.go
Outdated
crosbymichael
force-pushed
the
readall
branch
from
bc4612d to
15f67fe
Compare
libcontainer/utils/utils.go
Outdated
There was a problem hiding this comment.
@dqminh I'm pretty sure that Write will return io.ShortWrite before this line :) but it's ok I think
There was a problem hiding this comment.
yah thats true ( Write must return a non-nil error if it returns n < len(p)), so i dont think we need this check
|
LGTM |
Marshall the raw objects for the sync pipes so that no new line chars are left behind in the pipe causing errors. Signed-off-by: Michael Crosby <[email protected]>
crosbymichael
force-pushed
the
readall
branch
from
15f67fe to
ddcee3c
Compare
|
LGTM. @crosbymichael Not sure if we want to wait for the docker testing results to come back or not before merging. |
|
Tested the patch provided in #508 (comment) against docker 1.9.1 in production and it resolves our issue. Thanks! |
|
@csfrancis awesome! thanks for your help |
Do not use stream encoders for pipe communication
|
Nice! |
|
I have created moby/moby#19752 to bump the version in docker |
…number README: Update conference-call phone number
6 participants
Marshall the raw objects for the sync pipes so that no new line chars
are left behind in the pipe causing errors.
Signed-off-by: Michael Crosby [email protected]