Libcontainer README update to include factory for container creation #3632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
factory was missing from the libcontainer README, added what was missing from https://pkg.go.dev/github.com/opencontainers/runc/libcontainer#section-readme Signed-off-by: Niranjan Ravichandra <[email protected]>
readability fixes Signed-off-by: Niranjan Ravichandra <[email protected]>
Contributor
Author
|
Ahh my mistake then! Then the godocs are incorrect - I can open a PR to correct those instead. |
Contributor
|
Godocs are probably fine, too, but they are shown from the last released
version (1.1.4), which doesn't have these new changes. This, I guess, is
the source of confusion.
Thanks for looking into it.
…On Wed, Oct 12, 2022, 11:17 Niranjan Ravichandra ***@***.***> wrote:
Ahh my mistake then! Then the godocs are incorrect - I can open a PR to
correct those instead.
—
Reply to this email directly, view it on GitHub
<#3632 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCQEDNW7GTUVFXBEIZ6JFTWC36CHANCNFSM6AAAAAARC24CE4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was a little confused getting started with libcontainer today, which the package documentation helped with.
Quick PR to get parity w/ the docs to prevent further confusion.