libct/intelrdt: remove unused type #3305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commit 7296dc1, type intelRdtData is only used by tests, and since commit 79d292b, its only member is config. Change the test to use config directly, and remove the type. Signed-off-by: Kir Kolyshkin <[email protected]>
Contributor
Author
Contributor
|
@kolyshkin LGTM. |
marquiz
approved these changes
Dec 1, 2021
Contributor
marquiz
left a comment
marquiz
left a comment
There was a problem hiding this comment.
Thanks @kolyshkin. I could've spotted that myself 🙄
LGTM
xiaochenshen
approved these changes
Dec 1, 2021
AkihiroSuda
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PR #2920, type
intelRdtDatais only used by tests,and its only member is
config.Change the test to use config directly, and remove the type.
Partially generated by
sed -i -e 's/helper.IntelRdtData.config/helper.config/g' intelrdt_test.go