Skip to content

Conversation

@coolljt0725
Copy link
Member

Instead of using a constant as the runtime-spec
version, user Version in the package.

Signed-off-by: Lei Jitang [email protected]

Instead of using a constant as the runtime-spec
version, user `Version` in the package.

Signed-off-by: Lei Jitang <[email protected]>

var s specs.Spec
s.Version = "0.5.0"
s.Version = specs.Version
Copy link
Member

@runcom runcom Sep 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the runtime version not the image one right? if so this is wrong (do image and runtime follow same release? if so this is still wrong to me, but righter...)

@wking
Copy link
Contributor

wking commented Sep 22, 2016

On Thu, Sep 22, 2016 at 09:43:18AM -0700, Antonio Murdaca wrote:

@@ -70,7 +70,7 @@ func (c _config) runtimeSpec(rootfs string) (_specs.Spec, error) {
}

var s specs.Spec

  • s.Version = "0.5.0"
  • s.Version = specs.Version

this was the runtime version not the image one right? if so this is
wrong (do image and runtime follow same release? if so this is still
wrong to me, but righter...)

I think this change is right. It's using the runtime version
(specs.Version) to fill in a field on the generated runtime config.
With this PR, there's one less place to bump when image-tools moves to
new runtime-spec versions. Although with the approach made possible
by opencontainers/runtime-tools#219, we will be able to drop the
runtime-spec dependency completely.

@vbatts
Copy link
Member

vbatts commented Oct 6, 2016

LGTM

@vbatts vbatts merged commit 83de014 into opencontainers:master Oct 6, 2016
@coolljt0725 coolljt0725 deleted the non_constant_spec_version branch October 8, 2016 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants