image: Consistent reader usage #117
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it clear that this only needs the CAS-oriented Get and not the full walker. Signed-off-by: W. Trevor King <[email protected]>
Avoid locally implementing Get. Signed-off-by: W. Trevor King <[email protected]>
Avoid locally implementing Get. Signed-off-by: W. Trevor King <[email protected]>
wking
force-pushed
the
consistent-reader-usage
branch
from
2e92353 to
e815bc7
Compare
Both of these calls are to descriptor.validate(), which only needs a reader. Signed-off-by: W. Trevor King <[email protected]>
This is only getting CAS blobs, so we only need a reader. And there's no need to locally implement Get. Signed-off-by: W. Trevor King <[email protected]>
Now that we've ported manifest.unpack over to reader, we can replace the more-complicated walker implementation (which also provides for mutable-ref access) with the more-basic reader (which only interacts with CAS blobs). Signed-off-by: W. Trevor King <[email protected]>
wking
force-pushed
the
consistent-reader-usage
branch
from
e815bc7 to
27c98e0
Compare
Merged
Contributor
Author
|
It looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start distinguishing between
reader(when you only need toGetCAS blobs) andwalker(when you might also need to access mutable refs). This lays the ground work for something like #5, but avoids the contentious invention of new interfaces by sticking to interfaces which have already landed in master. Also removes a number of redundantGetre-implementations.