-
Notifications
You must be signed in to change notification settings - Fork 800
manifest-list: Drop HTTP Content-Type sentence #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As Adrian Colley points out [1], clients may not be aquiring the manifest over HTTP. In most cases, folks will know (from a Content-Type header, a descriptor media type, or other means) what type of blob they're dealing with before they look at the blob. I expect client behavior like [2]: If you can verify the digest, ignore Content-Type. If you can't verify the digest, respect the Content-Type and require it to match your expected media type (if any). But in the absence of an HTTP-API spec I don't think we need to talk about this at all. [1]: opencontainers#390 [2]: opencontainers#390 (comment) Signed-off-by: W. Trevor King <[email protected]>
6f15917 to
2c507b7
Compare
|
On Tue, Oct 18, 2016 at 07:46:35AM -0700, Jonathan Boulle wrote:
I'm fine with that or the guidelines I quote in the topic post. |
|
LGTM I like @jonboulle's suggestion; lets do this in media-types.md |
|
On Tue, Oct 18, 2016 at 09:07:21PM -0700, Brandon Philips wrote:
“COULD distinguish” isn't much guidance ;). Do you have specific
Would you change any of those? Recommend a different tree? Just |
This seems fine. Please file a followup PR. |
Fill in more generic detail for the advice which was removed in 2c507b7 (manifest-list: Drop HTTP Content-Type sentence, 2016-10-17, opencontainers#392). Signed-off-by: W. Trevor King <[email protected]>
As Adrian Colley points out in #390, clients may not be aquiring the manifest over HTTP. In most cases, folks will know (from a Content-Type header, a descriptor media type, or other means) what type of blob they're dealing with before they look at the blob. I expect client behavior like:
But in the absence of an HTTP-API spec I don't think we need to talk about this at all.
Fixes #390.