Update GitHub Actions configuration #1256
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
requested review from
jonjohnsonjr,
stevvooe,
sudo-bmitch,
sajayantony and
cyphar
as code owners
- remove meaningless badge
- also lint/test pushes (not just PRs)
- allow running the job explicitly on-demand ("workflow dispatch")
- cancel in-progress runs on PR update / push to the same branch
- explicitly limit GitHub token permissions
Signed-off-by: Tianon Gravi <[email protected]>
sudo-bmitch
reviewed
Apr 10, 2025
| @@ -1,8 +1,16 @@ | |||
| name: Render and Lint Documentation | |||
|
|
|||
| on: | |||
| push: | |||
There was a problem hiding this comment.
What if we split the difference. Limit the push to only the main branch, but allow pull requests on all branches.
Comment on lines
+8
to
+10
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
Does this mean a manual dispatch would kill the run for a pull request? I'm less concerned about multiple runs if we don't run on a push to every branch.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #1251