Skip to content

digest: update NewDigestFromHex signature to use Algorithm #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cyphar wants to merge 1 commit into from
Closed

digest: update NewDigestFromHex signature to use Algorithm #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion digest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func NewDigestFromBytes(alg Algorithm, p []byte) Digest {
}

// NewDigestFromHex returns a Digest from alg and a the hex encoded digest.
func NewDigestFromHex(alg, hex string) Digest {
func NewDigestFromHex(alg Algorithm, hex string) Digest {
return Digest(fmt.Sprintf("%s:%s", alg, hex))
}

Expand Down
2 changes: 1 addition & 1 deletion digest_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func TestParseDigest(t *testing.T) {
t.Fatalf("expected equal: %q != %q", newParsed, digest)
}

newFromHex := NewDigestFromHex(newParsed.Algorithm().String(), newParsed.Hex())
newFromHex := NewDigestFromHex(newParsed.Algorithm(), newParsed.Hex())
if newFromHex != digest {
t.Fatalf("%v != %v", newFromHex, digest)
}
Expand Down