Changed the Twitter logo #9854

MayaSatishRao · 2024-01-08T14:31:49Z

Resolve opencollective/opencollective#7195

Description

New Twitter (X) logo is added in the footer and header of open collective page

Screenshots

vercel · 2024-01-08T14:31:54Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
opencollective-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 30, 2024 1:18pm
opencollective-styleguide	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 30, 2024 1:18pm

components/collectives/sections/LearnMore.js

components/ContributorsGrid.js

Betree · 2024-01-09T11:10:37Z

components/ContributorsGrid.js

@@ -138,7 +138,6 @@ const ContributorsGrid = ({
 }) => {
  const maxNbRows = maxNbRowsForViewports[viewport];
  const [nbCols, nbRows] = getItemsRepartition(contributors.length, width, maxNbRows);
-


This change shouldn't be there either. I strongly recommend looking into https://jwiegley.github.io/git-from-the-bottom-up/1-Repository/8-interactive-rebasing.html, you'll save yourself a lot of energy

@Betree I have made the changes. And thanks for the resource that you shared.

Betree · 2024-01-09T15:30:27Z

I haven't tried locally, but this crashes the homepage on Vercel: https://opencollective-frontend-git-fork-mayasati-72655d-opencollective.vercel.app.

[Error: EMFILE: too many open files, open '/var/task/node_modules/@icons-pack/react-simple-icons/icons/SiGooglemaps.mjs'] {
  errno: -24,
  code: 'EMFILE',
  syscall: 'open',
  path: '/var/task/node_modules/@icons-pack/react-simple-icons/icons/SiGooglemaps.mjs',
  page: '/home'
}
Error: Runtime exited with error: exit status 1
Runtime.ExitError

MayaSatishRao · 2024-01-09T15:56:20Z

@Betree I found this phosphor-icons/react#45 (comment) and tried to make the changes accordingly. It was working fine locally but can you check if this resolves the error

Betree · 2024-01-17T08:01:33Z

@Betree I found this phosphor-icons/react#45 (comment) and tried to make the changes accordingly. It was working fine locally but can you check if this resolves the error

Still getting the same issue

MayaSatishRao · 2024-01-17T08:27:34Z

@Betree what should I do to remove this error? Should I use a different library instead of react-simple-icons?

Betree · 2024-01-17T11:13:53Z

@Betree what should I do to remove this error?

I have no clue on how to resolve this, and the resolution of this issue is not a priority so I can't invest time in researching solutions.

If you don't have the time to research it yourself, I suggest closing the PR and moving on to something more straightforward.

MayaSatishRao · 2024-01-17T11:46:19Z

@Betree can I use react-icons https://www.npmjs.com/package/react-icons instead of react-simple-icons?

Betree · 2024-01-29T15:17:12Z

I don't have the bandwidth to research and decide on an icon library. I suggest closing the PR if we can't make it work with the initial specs.

MayaSatishRao · 2024-01-29T16:17:29Z

@Betree I will look again for a solution. Please do not close this issue till then.

MayaSatishRao · 2024-01-29T19:40:16Z

@Betree Can you check it now?

Betree

This seems to work; thanks for iterating @MayaSatishRao!

The last thing we must do is rebase the PR on main to solve the conflicts.

MayaSatishRao · 2024-01-30T12:48:42Z

@Betree Do I need to perform rebase to solve conflict?

Betree · 2024-01-30T12:49:55Z

If you're not comfortable with it, I can take care of that part

MayaSatishRao · 2024-01-30T12:54:02Z

Can you please do the rebase part? I'm not sure on how to do this

Betree

@MayaSatishRao Your fix doesn't seem to work with the latest version of @icons-pack/react-simple-icons

MayaSatishRao · 2024-01-30T13:26:49Z

I updated react-simple-icons package to latest version and checked. It is working fine locally. But in the editor I am getting the error.

Betree · 2024-11-19T16:26:52Z

Resolved in #10810

Betree reviewed Jan 8, 2024

View reviewed changes

components/collectives/sections/LearnMore.js Outdated Show resolved Hide resolved

vercel bot deployed to Preview – opencollective-styleguide January 8, 2024 14:43 View deployment

vercel bot deployed to Preview – opencollective-frontend January 8, 2024 14:49 View deployment

vercel bot deployed to Preview – opencollective-frontend January 8, 2024 18:03 View deployment

vercel bot deployed to Preview – opencollective-styleguide January 8, 2024 18:05 View deployment

vercel bot deployed to Preview – opencollective-styleguide January 8, 2024 18:51 View deployment

vercel bot deployed to Preview – opencollective-frontend January 8, 2024 18:59 View deployment

Betree reviewed Jan 9, 2024

View reviewed changes

components/ContributorsGrid.js Outdated Show resolved Hide resolved

vercel bot deployed to Preview – opencollective-styleguide January 9, 2024 09:46 View deployment

vercel bot deployed to Preview – opencollective-frontend January 9, 2024 09:53 View deployment

Betree reviewed Jan 9, 2024

View reviewed changes

vercel bot deployed to Preview – opencollective-styleguide January 9, 2024 11:58 View deployment

vercel bot deployed to Preview – opencollective-frontend January 9, 2024 12:06 View deployment

MayaSatishRao force-pushed the linkChange branch from 5caf81d to a9cec05 Compare January 9, 2024 13:58

vercel bot deployed to Preview – opencollective-styleguide January 9, 2024 16:07 View deployment

vercel bot deployed to Preview – opencollective-frontend January 9, 2024 16:15 View deployment

Betree self-assigned this Jan 17, 2024

vercel bot deployed to Preview – opencollective-styleguide January 29, 2024 19:41 View deployment

vercel bot deployed to Preview – opencollective-frontend January 29, 2024 19:48 View deployment

Betree approved these changes Jan 30, 2024

View reviewed changes

MayaSatishRao and others added 5 commits January 30, 2024 13:59

Changed the twitter logo in footer and in opencollective page

12f2de5

removing changes unrelated to twitter logo change pr

be64062

Modified next.config.js fil to remove error by Vercel

573f99d

Changed the way in which twitter icon is imported

65c084d

deps(@icons-pack/react-simple-icons): fix version

2f0a99c

Betree force-pushed the linkChange branch from 2770847 to 2f0a99c Compare January 30, 2024 13:00

Betree reviewed Jan 30, 2024

View reviewed changes

vercel bot deployed to Preview – opencollective-styleguide January 30, 2024 13:10 View deployment

vercel bot deployed to Preview – opencollective-frontend January 30, 2024 13:18 View deployment

Betree closed this Nov 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changed the Twitter logo #9854

Changed the Twitter logo #9854

MayaSatishRao commented Jan 8, 2024 •

edited by Betree

Loading

vercel bot commented Jan 8, 2024 •

edited

Loading

Betree Jan 9, 2024

MayaSatishRao Jan 9, 2024

Betree commented Jan 9, 2024

MayaSatishRao commented Jan 9, 2024 •

edited

Loading

Betree commented Jan 17, 2024

MayaSatishRao commented Jan 17, 2024

Betree commented Jan 17, 2024

MayaSatishRao commented Jan 17, 2024

Betree commented Jan 29, 2024

MayaSatishRao commented Jan 29, 2024

MayaSatishRao commented Jan 29, 2024

Betree left a comment

MayaSatishRao commented Jan 30, 2024

Betree commented Jan 30, 2024

MayaSatishRao commented Jan 30, 2024

Betree left a comment

MayaSatishRao commented Jan 30, 2024 •

edited

Loading

Betree commented Nov 19, 2024

Changed the Twitter logo #9854

Changed the Twitter logo #9854

Conversation

MayaSatishRao commented Jan 8, 2024 • edited by Betree Loading

Description

Screenshots

vercel bot commented Jan 8, 2024 • edited Loading

Betree Jan 9, 2024

Choose a reason for hiding this comment

MayaSatishRao Jan 9, 2024

Choose a reason for hiding this comment

Betree commented Jan 9, 2024

MayaSatishRao commented Jan 9, 2024 • edited Loading

Betree commented Jan 17, 2024

MayaSatishRao commented Jan 17, 2024

Betree commented Jan 17, 2024

MayaSatishRao commented Jan 17, 2024

Betree commented Jan 29, 2024

MayaSatishRao commented Jan 29, 2024

MayaSatishRao commented Jan 29, 2024

Betree left a comment

Choose a reason for hiding this comment

MayaSatishRao commented Jan 30, 2024

Betree commented Jan 30, 2024

MayaSatishRao commented Jan 30, 2024

Betree left a comment

Choose a reason for hiding this comment

MayaSatishRao commented Jan 30, 2024 • edited Loading

Betree commented Nov 19, 2024

MayaSatishRao commented Jan 8, 2024 •

edited by Betree

Loading

vercel bot commented Jan 8, 2024 •

edited

Loading

MayaSatishRao commented Jan 9, 2024 •

edited

Loading

MayaSatishRao commented Jan 30, 2024 •

edited

Loading