Skip to content

Conversation

@Krishna200608
Copy link
Contributor

Issue: #173

πŸ“Œ Description

Implemented full edit and delete functionality for subscriptions with confirmation dialogs and toast notifications.

  • Users can now update subscription details (name, amount, billing cycle, renewal date, status, etc.)
  • Users can delete subscriptions with explicit confirmation to prevent accidental data loss
  • Toast notifications provide immediate feedback for all actions
  • UI updates instantly without page reload

🧩 Issue Reference

Related Issue: #173


πŸ› οΈ What Did You Implement?

  • Feature implementation
  • UI changes
  • API / backend logic
  • Refactor / cleanup
  • Documentation update
  • Demo / setup task

Features:

  • EditSubscriptionModal - Prefilled form with all subscription fields
  • DeleteConfirmDialog - Confirmation dialog before deletion
  • PUT /api/subscriptions/:id - Update subscription endpoint
  • DELETE /api/subscriptions/:id - Delete subscription endpoint
  • Toast notifications (sonner) for success/error feedback
  • Instant UI updates after edit/delete

πŸ“ Workspace Confirmation (MANDATORY)

  • All changes are inside contributors/Krishna200608/
  • Base client/ and/or server/ files were copied from the main directory
  • No files outside my personal workspace were modified

πŸ§ͺ Testing Performed

  • Frontend runs locally without errors
  • Backend server runs locally without errors
  • APIs tested with valid inputs
  • APIs tested with invalid / edge-case inputs
  • No console errors or warnings

πŸ“· Screenshots / Demo (REQUIRED for most PRs)

1.mp4
  1. Edit Modal with prefilled data
  2. Delete confirmation dialog
  3. Success toast after edit
  4. Success toast after delete
  5. Updated subscription list

βœ… Final PR Checklist

  • This PR addresses only one issue
  • Issue number is mentioned at the top
  • Code is readable and well-structured
  • No unnecessary files are included
  • No sensitive data or .env files committed
  • Commit messages follow project conventions
  • PR title is clear and descriptive

πŸ“Ž Additional Notes for Reviewers

  • Used Radix UI Dialog/AlertDialog for modals (consistent with existing UI)
  • Used sonner for toast notifications (lightweight, dark theme support)
  • Backend endpoints verify user ownership before edit/delete
  • Form validation matches the Add Subscription form

@OpenGitBot
Copy link

Hey @Krishna200608

Thanks for opening this PR πŸš€. Mentor will review your pull request soon and till then, keep contributing and stay calm.

Thanks for contributing in OpenCode'25 ✨✨!

@ShubhamKumarSahu-svg ShubhamKumarSahu-svg merged commit 05a64b6 into opencodeiiita:main Jan 9, 2026
@OpenGitBot
Copy link

Hey @Krishna200608

Your PR has been merged πŸ₯³πŸ₯³ and you have earned 40 points.

Thanks for contributing in OpenCode'25✨✨

@Krishna200608 Krishna200608 deleted the feature/manage-subscriptions-ui-173 branch January 9, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants