Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSCM toolbox loadPSCMfile function bug fix and merge conflict resolve #2459

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

trjhensen
Copy link
Contributor

This pull request is an update from an earlier pull request that contained a merge conflict. The previous pull request is closed and is replaced by this pull request with a solution to the merge conflict.

A fix was made to prevent an error if loadPSCMfile was used on a mac on linux machine by replacing line 137 from:
from -> searchDirectory = what(['2020_WholeBodyModelling/Data']).path;
to -> searchDirectory = what(['2020_WholeBodyModelling' filesep 'Data']).path;

Another fix was made that caused an error when the PSCM file was a structured .mat file.

The following change was made from:
from -> model = model.(string(fieldnames(model)));
to ->
if isscalar(fieldnames(model))
% Loading the model in a variable might make it nested. Unnest variable
model = model.(string(fieldnames(model)));
end

I hereby confirm that I have:

[X] Tested my code on my own machine
[X] Followed the guidelines in the Contributing Guide
[X] Selected develop as a target branch (top left drop-down menu)

Copy link
Contributor

Summary:

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️
235 188 0 47

Failed Tests:

No failed tests ✨

Github Test Reporter by CTRF 💚

@farid-zare farid-zare merged commit eccd899 into opencobra:develop Mar 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants