Skip to content

externalProxyDocs: add conf for tus upload#500

Merged
ScharfViktor merged 1 commit into
mainfrom
externalProxyDocs-addClientMaxBodySizeForTus
Nov 10, 2025
Merged

externalProxyDocs: add conf for tus upload#500
ScharfViktor merged 1 commit into
mainfrom
externalProxyDocs-addClientMaxBodySizeForTus

Conversation

@ScharfViktor

Copy link
Copy Markdown
Contributor

following this plan I couldn't upload date more than 1mb - fixed it

Copilot AI review requested due to automatic review settings November 6, 2025 12:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the nginx reverse proxy configuration for OpenCloud by adding essential settings for handling file uploads, Server-Sent Events (SSE), and long-running connections.

  • Increases client max body size to support file uploads via Tus protocol
  • Disables proxy buffering to enable SSE functionality
  • Extends timeouts for long-running connections and prevents fallback to alternative upstreams

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/admin/getting-started/container/docker-compose/docker-external-proxy.md Outdated
Comment thread docs/admin/getting-started/container/docker-compose/docker-external-proxy.md Outdated
@ScharfViktor

Copy link
Copy Markdown
Contributor Author

need also adjust collabora config because I get 413 Request Entity Too Large when I try to insert image inside the .odt document

@ScharfViktor ScharfViktor force-pushed the externalProxyDocs-addClientMaxBodySizeForTus branch from 585c321 to 4aef154 Compare November 6, 2025 14:31
@ScharfViktor

Copy link
Copy Markdown
Contributor Author

need also adjust collabora config because I get 413 Request Entity Too Large when I try to insert image inside the .odt document

fixed

@Svanvith

Svanvith commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

I will test it, but should we also add a part in the "common issues" section?
Smth like "upload bigger than 1MB failed" and then explain that when you use an external proxy you need to adjust the config?

@ScharfViktor

ScharfViktor commented Nov 6, 2025

Copy link
Copy Markdown
Contributor Author

I will test it

okay, steps for reproduce

Expected: it possible to upload file more than 1mb
Actual: getting 413 Request Entity Too Large. my changes fixed it

but should we also add a part in the "common issues" section? Smth like "upload bigger than 1MB failed" and then explain that when you use an external proxy you need to adjust the config?

Yes, that's a good idea. But I would also keep my changes here so that people don't encounter the problem and look for a solution.

@Svanvith Svanvith left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved 👍

@ScharfViktor ScharfViktor merged commit 1ab6848 into main Nov 10, 2025
3 checks passed
@ScharfViktor ScharfViktor deleted the externalProxyDocs-addClientMaxBodySizeForTus branch November 10, 2025 11:50
@openclouders openclouders mentioned this pull request Nov 10, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants