test(gui): fix and enable settings test scenarios#911
Merged
Conversation
saw-jan
force-pushed
the
test/enable-settings-checks
branch
from
0692580 to
4c960e0
Compare
| @@ -3,7 +3,7 @@ Feature: Visually check all tabs | |||
| I want to visually check all tabs in client | |||
| So that I can perform all the actions related to client | |||
|
|
|||
|
|
|||
| @smoke | |||
| Scenario: Tabs in toolbar looks correct | |||
Contributor
There was a problem hiding this comment.
The tests fails.
Am i doing something wrong?
Scenario: Verify various setting options in Settings tab # features/tabs-settings/test.feature:17
Given user "Alice" has been created in the server with default attributes # steps/server_context.py:8 0.072s
And user "Alice" has set up a client with default settings # steps/account_context.py:55
Traceback (most recent call last):
File "/home/prashant/Desktop/projects/oc-desktop/desktop/test/gui/venv/lib/python3.12/site-packages/behave/model.py", line 1991, in run
match.run(runner.context)
File "/home/prashant/Desktop/projects/oc-desktop/desktop/test/gui/venv/lib/python3.12/site-packages/behave/matchers.py", line 105, in run
self.func(context, *args, **kwargs)
File "steps/account_context.py", line 62, in step
enter_password.login_after_setup(username, password)
File "/home/prashant/Desktop/projects/oc-desktop/desktop/test/gui/pageObjects/EnterPassword.py", line 39, in login_after_setup
self.oidc_relogin(username, password)
File "/home/prashant/Desktop/projects/oc-desktop/desktop/test/gui/pageObjects/EnterPassword.py", line 33, in oidc_relogin
authorize_via_webui(username, password)
File "/home/prashant/Desktop/projects/oc-desktop/desktop/test/gui/helpers/WebUIHelper.py", line 12, in authorize_via_webui
page.goto(url)
File "/home/prashant/Desktop/projects/oc-desktop/desktop/test/gui/venv/lib/python3.12/site-packages/playwright/sync_api/_generated.py", line 9054, in goto
self._sync(
File "/home/prashant/Desktop/projects/oc-desktop/desktop/test/gui/venv/lib/python3.12/site-packages/playwright/_impl/_sync_base.py", line 115, in _sync
return task.result()
^^^^^^^^^^^^^
File "/home/prashant/Desktop/projects/oc-desktop/desktop/test/gui/venv/lib/python3.12/site-packages/playwright/_impl/_page.py", line 552, in goto
return await self._main_frame.goto(**locals_to_params(locals()))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/prashant/Desktop/projects/oc-desktop/desktop/test/gui/venv/lib/python3.12/site-packages/playwright/_impl/_frame.py", line 153, in goto
await self._channel.send(
File "/home/prashant/Desktop/projects/oc-desktop/desktop/test/gui/venv/lib/python3.12/site-packages/playwright/_impl/_connection.py", line 69, in send
return await self._connection.wrap_api_call(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/prashant/Desktop/projects/oc-desktop/desktop/test/gui/venv/lib/python3.12/site-packages/playwright/_impl/_connection.py", line 559, in wrap_api_call
raise rewrite_error(error, f"{parsed_st['apiName']}: {error}") from None
playwright._impl._errors.Error: Page.goto: Protocol error (Page.navigate): Cannot navigate to invalid URL
Call log:
- navigating to "Cannot navigate to invalid URL", waiting until "load"
Contributor
Author
There was a problem hiding this comment.
browser login failed.
Contributor
There was a problem hiding this comment.
I am also facing same issue
Contributor
Author
There was a problem hiding this comment.
hmm, that's weird. Could you check your chromium version?
Contributor
Author
There was a problem hiding this comment.
or check with headed mode to see what happens:
Contributor
There was a problem hiding this comment.
Yes it accessible.
Contributor
There was a problem hiding this comment.
This scenario is fine.
Scenario: Tabs in toolbar looks correctBut another one is failing:
Scenario: Verify various setting options in Settings tab # features/tabs-settings/tabsSettings.feature:17
Given user "Alice" has been created in the server with default attributes # steps/server_context.py:8 0.070s
And user "Alice" has set up a client with default settings # steps/account_context.py:55
And user "Alice" has set up a client with default settings # steps/account_context.py:55 2.801s
When the user opens the settings tab # steps/sync_context.py:86 0.217s
ASSERT FAILED: Settings tab is not active
Contributor
There was a problem hiding this comment.
Yes, that's correct in this test case as well.
Contributor
Author
There was a problem hiding this comment.
let's see into this issue separately.
saw-jan
force-pushed
the
test/enable-settings-checks
branch
from
4c960e0 to
2491dd3
Compare
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
saw-jan
force-pushed
the
test/enable-settings-checks
branch
from
2491dd3 to
f512770
Compare
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
saw-jan
force-pushed
the
test/enable-settings-checks
branch
from
3fd26f1 to
67889e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed and enabled the following test scenarios
Fixes #849
Closes #850