fix: sync install.sh with openclaw/openclaw#129
Open
SebTardif wants to merge 2 commits intoopenclaw:mainfrom
Open
fix: sync install.sh with openclaw/openclaw#129SebTardif wants to merge 2 commits intoopenclaw:mainfrom
SebTardif wants to merge 2 commits intoopenclaw:mainfrom
Conversation
Full sync of public/install.sh with the canonical scripts/install.sh from openclaw/openclaw (main branch as of 2026-05-03). Includes changes from multiple PRs that were never propagated: - Progress indicators during quiet steps (#71720) - Progress during npm install in non-interactive mode (#76355) - Arch Linux support - Node version handling improvements (v24 default, v22.14 minimum) - Gum spinner raw-mode detection fixes - apt-get helper functions - Removed legacy CLAWDBOT env var mapping - Removed --profile/--workspace/--gateway-port flags - Added --verify flag
|
@SebTardif is attempting to deploy a commit to the Jamie's projects Team on Vercel. A member of the Team first needs to authorize it. |
| gum_out="$(mktempfile)" | ||
| if "$GUM" spin --spinner dot --title "$title" -- "$@" >"$gum_out" 2>"$gum_err"; then | ||
| if is_gum_raw_mode_failure "$gum_out" || is_gum_raw_mode_failure "$gum_err"; then | ||
| GUM="" |
Author
There was a problem hiding this comment.
This is pre-existing logic in the canonical scripts/install.sh from openclaw/openclaw. This PR is a direct file sync — the behavior is intentional fallback: when gum reports success (exit 0) but the output contains raw mode errors (meaning gum silently failed to display the spinner), the command is re-executed without gum to ensure it actually ran correctly.
If this is a real concern, it should be addressed upstream in openclaw/openclaw, not in this sync PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
public/install.sh(served athttps://openclaw.ai/install.sh) is significantly out of sync with the canonicalscripts/install.shin openclaw/openclaw. The diff is ~945 lines across many PRs that were never propagated.Users running
curl -fsSL https://openclaw.ai/install.sh | bashare missing:--verifyflag for post-install smoke testsAnd still include removed features:
--profile/--workspace/--gateway-portflagsensure_home_env,resolve_brew_bin,activate_brew_for_session(replaced by simpler logic)Fix
Full file replacement with the current
scripts/install.shfrom openclaw/openclaw main branch. SHA256 verified match.Related