Resolve bundled plugins from flake input instead of hardcoded rev#71
Draft
dansanduleac wants to merge 1 commit intoopenclaw:mainfrom
Draft
Resolve bundled plugins from flake input instead of hardcoded rev#71dansanduleac wants to merge 1 commit intoopenclaw:mainfrom
dansanduleac wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Author
|
The CI failures ( This is unrelated to the changes in this PR. The |
Replace hardcoded rev/narHash in lib.nix with direct sub-flake evaluation from the nix-steipete-tools flake input. This: - Eliminates "not writing modified lock file" warnings caused by builtins.getFlake on sub-flakes without committed flake.lock files - Allows downstream consumers to override nix-steipete-tools via the standard flake input/follows mechanism instead of being pinned to a hardcoded revision - Introduces a "bundled:" URI scheme in plugins.nix that imports and evaluates sub-flakes directly from the source tree The nix-steipete-tools input is threaded to the HM module via _module.args.steipeteToolsInput, set once at the flake output level. Only lib.nix and plugins.nix (which are plain Nix files, not modules) receive it via explicit function arguments. Co-Authored-By: Claude Opus 4.6 <[email protected]>
dansanduleac
force-pushed
the
fix/steipete-tools-from-flake-input
branch
from
850673d to
d17cc76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stepieteRev/stepieteNarHashinlib.nixwith direct sub-flake evaluation from thenix-steipete-toolsflake inputnot writing modified lock filewarnings caused bybuiltins.getFlakeon sub-flakes without committedflake.lockfilesnix-steipete-toolsvia the standard flakefollowsmechanismApproach
bundled:URI scheme:lib.nixproducesbundled:steipete/<tool>source stringsplugins.nixhandles these by importing and evaluating the sub-flake directly from thenix-steipete-toolssource tree, bypassingbuiltins.getFlakeentirelybuiltins.getFlakeas beforenix-steipete-toolsinput is threaded through the module system via the standard closure patternDependencies
nix-steipete-toolsinput todansanduleac/nix-steipete-tools(Add flake.lock for tools/summarize sub-flake nix-steipete-tools#8) which addstools/summarize/flake.lock— revert toopenclaw/nix-steipete-toolsonce that's mergedTest plan
nix flake checkpasses with nonot writing modified lock filewarningsbuiltins.getFlake🤖 Generated with Claude Code