Skip to content

feat(runtime): re-export RuntimeOptions from package entry#202

Merged
steipete merged 1 commit into
openclaw:mainfrom
feniix:feat/export-runtime-options
Jun 7, 2026
Merged

feat(runtime): re-export RuntimeOptions from package entry#202
steipete merged 1 commit into
openclaw:mainfrom
feniix:feat/export-runtime-options

Conversation

@feniix

@feniix feniix commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Re-exports RuntimeOptions from src/index.ts so consumers wrapping createRuntime can name the parameter type directly instead of reaching for Parameters<typeof createRuntime>[0].
  • Reformats the existing single-line from './runtime.js' type export into a multi-line block so future additions stay reviewable.

Strictly additive. RuntimeOptions's transitive references (ServerDefinition, RuntimeLogger) are already public from src/index.ts, so this is a true one-liner with no cascading exports.

Closes #200.

Test plan

  • pnpm check (format + lint + typecheck) — green
  • pnpm test (706 tests, 3 skipped) — green
  • Verified consumers can import type { RuntimeOptions } from 'mcporter' (typecheck via tsgo).

createRuntime is the package's primary library entry point but its
parameter type RuntimeOptions was not re-exported from src/index.ts.
Consumers wrapping createRuntime had to reach for
Parameters<typeof createRuntime>[0] just to name the shape — the
same friction openclaw#199 is filed to eliminate for Runtime.connect's
ConnectOptions.

Strictly additive. RuntimeOptions's transitive references
(ServerDefinition, RuntimeLogger) are already public, so this is a
true one-liner with no cascading exports. Wrapped the existing
single-line export into a multi-line block to keep the diff
reviewable as the list grows.

Closes openclaw#200.
@clawsweeper

clawsweeper Bot commented Jun 6, 2026

Copy link
Copy Markdown

Codex review: needs real behavior proof before merge. Reviewed June 6, 2026, 12:40 PM ET / 16:40 UTC.

Summary
Review failed before ClawSweeper could summarize the requested change.

Reproducibility: unclear. The review failed before ClawSweeper could establish a reproduction path.

Review metrics: none identified.

Merge readiness
Overall: 🌊 off-meta tidepool
Proof: 🌊 off-meta tidepool
Patch quality: 🌊 off-meta tidepool
Result: rating does not apply to this item.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Risk before merge

  • [P1] No close action taken because the review did not complete.

Maintainer options:

  1. Decide the mitigation before merge
    Retry the Codex review after fixing the execution failure.
  2. Pause or close
    Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

  • [P1] Review did not complete, so no work-lane recommendation was made.
Review details

Best possible solution:

Retry the Codex review after fixing the execution failure.

Do we have a high-confidence way to reproduce the issue?

Unclear. The review failed before ClawSweeper could establish a reproduction path.

Is this the best way to solve the issue?

Unclear. Retry the review first so ClawSweeper can evaluate the actual issue and fix direction.

AGENTS.md: unclear because the file could not be read completely.

Codex review notes: model gpt-5.5, reasoning high; reviewed against 2bf7a5eab23f.

Label changes

Label changes:

  • add rating: 🌊 off-meta tidepool: Overall readiness is 🌊 off-meta tidepool; proof is 🌊 off-meta tidepool and patch quality is 🌊 off-meta tidepool.

Label justifications:

  • rating: 🌊 off-meta tidepool: Overall readiness is 🌊 off-meta tidepool; proof is 🌊 off-meta tidepool and patch quality is 🌊 off-meta tidepool.
Evidence reviewed

What I checked:

  • failure reason: timeout.
  • codex failure detail: Codex review failed for this PR: spawnSync codex ETIMEDOUT.
  • codex stdout: Per-item Codex failure; continuing with the rest of the shard.

Likely related people:

  • unknown: Codex failed before it could trace repository history. (role: review did not complete; confidence: low)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@clawsweeper clawsweeper Bot added the rating: 🌊 off-meta tidepool PR readiness rating does not apply to this item. label Jun 6, 2026
@steipete steipete merged commit f37a642 into openclaw:main Jun 7, 2026
3 checks passed
@steipete

steipete commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

Merged in f37a642.

Verified on head 8bf20fe:

  • pnpm docs:list
  • pnpm check
  • pnpm test (123 files passed, 1 skipped; 706 tests passed, 3 skipped)
  • pnpm build
  • rg -n "RuntimeOptions" dist/index.d.ts dist/runtime.d.ts confirmed the built declaration barrel exports the type.
  • Autoreview branch vs origin/main: clean, no accepted/actionable findings.
  • Existing PR CI green: ubuntu-latest, macos-15, windows-latest.

Thanks @feniix.

@feniix feniix deleted the feat/export-runtime-options branch June 10, 2026 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rating: 🌊 off-meta tidepool PR readiness rating does not apply to this item.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose RuntimeOptions as a public type

2 participants