feat(runtime): re-export RuntimeOptions from package entry#202
Conversation
createRuntime is the package's primary library entry point but its parameter type RuntimeOptions was not re-exported from src/index.ts. Consumers wrapping createRuntime had to reach for Parameters<typeof createRuntime>[0] just to name the shape — the same friction openclaw#199 is filed to eliminate for Runtime.connect's ConnectOptions. Strictly additive. RuntimeOptions's transitive references (ServerDefinition, RuntimeLogger) are already public, so this is a true one-liner with no cascading exports. Wrapped the existing single-line export into a multi-line block to keep the diff reviewable as the list grows. Closes openclaw#200.
|
Codex review: needs real behavior proof before merge. Reviewed June 6, 2026, 12:40 PM ET / 16:40 UTC. Summary Reproducibility: unclear. The review failed before ClawSweeper could establish a reproduction path. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Risk before merge
Maintainer options:
Next step before merge
Review detailsBest possible solution: Retry the Codex review after fixing the execution failure. Do we have a high-confidence way to reproduce the issue? Unclear. The review failed before ClawSweeper could establish a reproduction path. Is this the best way to solve the issue? Unclear. Retry the review first so ClawSweeper can evaluate the actual issue and fix direction. AGENTS.md: unclear because the file could not be read completely. Codex review notes: model gpt-5.5, reasoning high; reviewed against 2bf7a5eab23f. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Merged in f37a642. Verified on head 8bf20fe:
Thanks @feniix. |
Summary
RuntimeOptionsfromsrc/index.tsso consumers wrappingcreateRuntimecan name the parameter type directly instead of reaching forParameters<typeof createRuntime>[0].from './runtime.js'type export into a multi-line block so future additions stay reviewable.Strictly additive.
RuntimeOptions's transitive references (ServerDefinition,RuntimeLogger) are already public fromsrc/index.ts, so this is a true one-liner with no cascading exports.Closes #200.
Test plan
pnpm check(format + lint + typecheck) — greenpnpm test(706 tests, 3 skipped) — greenimport type { RuntimeOptions } from 'mcporter'(typecheck via tsgo).