Repository navigation
chore(autoreview): use the shared canonical skill - #97
Conversation
|
Codex review: blocked before merge. Reviewed October 6, 2026, 1:46 PM ET / 17:46 UTC (Revision 10). ClawSweeper reviewWhat this changesThe branch replaces copied autoreview scripts and tests with a shared-skill entrypoint and updates contributor handoff commands and the changelog. Regression provenancePossible regression — suspected (reviewed change). No predecessor PR is attributed. Merge readiness⛔ Blocked before merge - 3 items remain The shared-installation cutover remains useful and is absent from current main. The previously reported severity-coverage regression remains unfixed; the member-authored PR should stay open. Priority: P3 Review scores
Verification
How this fits togetherAutoreview checks contributors’ proposed changes before handoff. This cutover sends those changes to a separately installed shared helper, whose severity settings determine which findings block handoff. flowchart LR
A[Contributor changes] --> B[Repository handoff command]
B --> C[Shared review helper]
C --> D[Severity threshold]
D --> E[Actionable findings]
E --> F[Handoff result]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Use the canonical shared installation while explicitly preserving this repository’s full actionable-finding coverage. Do we have a high-confidence way to reproduce the issue? Yes, from source: with AUTOREVIEW_MAX_PRIORITY unset, both replacement commands select the shared helper’s P0-only prompt and filtering. No helper or runtime execution was performed. Is this the best way to solve the issue? Yes, centralizing the copied implementation is appropriate, provided the two handoff commands explicitly retain P0–P3 coverage. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 15e44ec7fb75. LabelsLabel changes: No label changes. Label justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (9 earlier review cycles; latest 8 shown)
|
|
🦞👀 Pull request received. I will update this pull request when review starts. |
What Problem This Solves
Repository-local autoreview copies drift and can retain retired prerequisites such as TruffleHog.
User Impact
Install autoreview once from
openclaw/agent-skillsusing the setup linked in.agents/skills/autoreview/SKILL.md. Reviews run from this repository through that shared installation. Updating its source checkout updates all symlinked consumers; copy-mode users reinstall once. Product runtime behavior is unchanged.Why This Change Was Made
Keep only the canonical Markdown entrypoint and remove the copied helper, fixtures, and implementation tests.
Canonical owner and preserved downstream fixes: openclaw/agent-skills#305. Shared changes belong upstream; review runs do not download or update code automatically.
Evidence
git diff --checkpasses; independent integration review checked callers and removed gates.Landing follow-up
Repository instructions explicitly retain the original P0–P3 review gate with
--max-priority P3; direct invocation examples use that override. The shared entrypoint remains identical to the canonical template.