Repository navigation
build(deps): refresh formatter, lint, and Node setup - #103
Conversation
Combine the routine dependency updates and apply the import ordering now enforced by oxfmt in Markdown code blocks. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesUpdates oxfmt, oxlint, and the pinned Node setup action, with the README import order required by the new formatter. Example: Run repository formatting checks with oxfmt 0.72.0.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this PR consolidates useful dependency maintenance absent from current main, addresses the formatter compatibility change, and has passing checks with no actionable findings. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherDevelopment dependencies and GitHub Actions prepare Node and pnpm, validate repository source, and support protected tag-driven npm releases. flowchart TD
A[Repository source] --> B[Node and pnpm setup]
C[Dependency lockfile] --> B
B --> D[Formatter and linter]
B --> E[Package and browser checks]
D --> F[Validation results]
E --> F
F --> G[Protected tag release]
Technical reviewBest possible solution: Land the focused dependency refresh with its README compatibility adjustment and existing maintenance boundaries. Do we have a high-confidence way to reproduce the issue? This is dependency maintenance; the formatter incompatibility is described in the body and the adjusted head passes repository checks, but no local reproduction was run. Is this the best way to solve the issue? Updating the existing dependencies and action pins, with the small formatting adjustment, preserves the established tooling ownership without adding parallel paths. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against fc0f56595507. Provenance checked
TestingProof path: none. SecurityNone. EvidenceWhat I checked:
Likely related people:
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 10, 2026, 3:23 AM ET / 07:23 UTC. |
Update oxfmt to 0.72.0, oxlint to 1.87.0, and the pinned actions/setup-node action to 7.1.0. This consolidates #101 and #102 and preserves the two-day dependency cooldown, Node runtime support, pnpm 11 toolchain, and package version.
The formatter update made all check jobs in #101 fail because it now sorts imports inside Markdown code blocks. Reproduced that failure and applied the formatter's two-line import reorder in README.md. Added the Unreleased changelog entry and retained Dependabot's contribution credit.
Validation on Linux with the repository's pnpm 11.28.0:
pnpm install --frozen-lockfilepnpm check: formatting, build, type checks, lint, all 140 tests, and packed-package import checks pass.pnpm test:coverage: all 140 tests pass.pnpm test:browser: all 9 Chromium tests pass with Node and Worker assets.